Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

URGENT: pin nf-validation version #144

Closed
nvnieuwk opened this issue Feb 22, 2024 · 6 comments · Fixed by #146
Closed

URGENT: pin nf-validation version #144

nvnieuwk opened this issue Feb 22, 2024 · 6 comments · Fixed by #146
Labels
bug Something isn't working

Comments

@nvnieuwk
Copy link

Description of the bug

To prevent breaking this pipeline in the near future, the nf-validation version should be pinned to version 1.1.3 like:

plugins {
    id '[email protected]'
}

Command used and terminal output

No response

Relevant files

No response

System information

No response

@nvnieuwk nvnieuwk added the bug Something isn't working label Feb 22, 2024
@mirpedrol
Copy link
Member

Hello!

⚠️ The nf-validation plugin will have soon a new release (v2.0) which has breaking changes.
This will break the usage of all pipelines that don't pin the version of this plugin, as Nextflow tries to pull the latest version.

  • ❓ How to pin the version:
    Add this to your nextflow.config file (notice the @1.1.3):
plugins {
    [email protected]
}
  • 🚨 Release a patch release as soon as possible!
    Either if you already pinned the version on your dev branch or if you are going to add it now, please release this changes ASAP, to avoid breaking the usage of the latest version of your pipeline when the new version of nf-validation comes out.

  • 🤓 How to use the new version of nf-validation?
    If you want to be prepared for the new version of nf-validation, this will use the latest version of a JSON Schema draft. You will have to update the nextflow_schema.json and input_schema.json files (and any other JSON schemas that you use!).
    You can find a migration guide here.

@jpfeuffer jpfeuffer mentioned this issue Mar 21, 2024
10 tasks
@ypriverol
Copy link
Member

PR for the Template update here bigbio#358

@jpfeuffer
Copy link
Collaborator

@ypriverol I don't think this will be solved by a template update. We have to change it manually

@ypriverol
Copy link
Member

ypriverol commented Mar 21, 2024

But it passes all the tests. @mirpedrol Can you check this PR which pass all the tests for the next released template if it solve the issue? bigbio#358

@mirpedrol
Copy link
Member

Hello @ypriverol,
I see you have the version of nf-validation pinned in the dev branch. This specifies which version of the plugin to use. It would be good to have it in the master branch too, so to do a release of the pipeline soon.

@ypriverol ypriverol linked a pull request Mar 21, 2024 that will close this issue
10 tasks
@ypriverol ypriverol linked a pull request Apr 8, 2024 that will close this issue
10 tasks
@ypriverol
Copy link
Member

this has been done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants