Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Usability tests/improvements #138

Closed
jpfeuffer opened this issue Jan 20, 2024 · 1 comment
Closed

Usability tests/improvements #138

jpfeuffer opened this issue Jan 20, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement Improvement for existing functionality feature-request Request for a new pipeline feature

Comments

@jpfeuffer
Copy link
Collaborator

I think we have the basic features ready in this pipeline.

@ypriverol @timosachsenberg

Unfortunately most bug reports that we receive are from people struggling with SDRF or getting errors in the middle of the pipeline because of erroneous SDRFs.
I think we should significantly extend and improve both the checks and error messages in multiple steps, starting with SDRF parsing before focusing on even more complicated designs such as TMT with MBR. We can add erroneous SDRFs to the sdrf-pipelines repository and make sure that reasonable error messages are given. We can add several validation levels: for openms, for quantms, for quantms with MSstats (or downstream statistics), with each level requiring more information. We maybe should even invest in a basic UI component to more easily complete an SDRF in a way that is suitable for this pipeline. We can build on lesSDRF.

Other steps that would benefit from error handling are ID and filtering steps, where we could double-check that ID files are not empty.

Maintainers should also make sure to forward bad error handling to the upstream tools such as OpenMS.

@jpfeuffer jpfeuffer added bug Something isn't working documentation Improvements or additions to documentation enhancement Improvement for existing functionality feature-request Request for a new pipeline feature labels Jan 20, 2024
@ypriverol
Copy link
Member

Im moving this SDRF issue to sdrf-pipelines to get better message errors. Agreed with you here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement Improvement for existing functionality feature-request Request for a new pipeline feature
Projects
None yet
Development

No branches or pull requests

2 participants