Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dragmap #73

Open
ewels opened this issue Dec 11, 2024 · 4 comments
Open

dragmap #73

ewels opened this issue Dec 11, 2024 · 4 comments

Comments

@ewels
Copy link
Member

ewels commented Dec 11, 2024

Quoting @dslarm :


bunch of x86 specific compile flags, and also use of x86 intrinsics. Any volunteers? There’s a simple #include that will solve this (as per bwa-mem2 and hisat2)

@maxulysse
Note that the latest dragmap is not working, which is why we patched it to an older version in sarek

so we use dragmap=1.2.1 + samtools=1.19.2 and pigz=2.3.4

@ewels ewels converted this from a draft issue Dec 11, 2024
@delagoya
Copy link

@lrbison
Copy link

lrbison commented Jan 29, 2025

I have a DRAGMAP build from source working on arm64 now. Working on testing to make sure I didn't disable anything on x86 either.

One odd thing is that I cannot see DRAGMAP in bioconda on my arm instance at all. Must need some additional recipe configuration (https://bioconda.github.io/recipes/dragmap/README.html)

One concern is https://github.com/Illumina/DRAGMAP/blob/master/thirdparty/dragen/src/common/hash_generation/hash_table.c#L2223 but it seems that the atomic updates should do the synchronization without additional asm sections.

@lrbison
Copy link

lrbison commented Jan 30, 2025

PR to DRAGMAP based on master is up: Illumina/DRAGMAP#65
Although according to their page, they are not accepting PRs. We'll have to pull in a patch.

My PR doesn't cleanly backport to dragmap=1.2.1. I will make another if necessary.

@delagoya
Copy link

Nice. I am looking into how we can get the PR reviewed and accepted by DRAGEN team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants