Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubs and test for rnaseq modules - part V #6009

Merged
merged 30 commits into from
Jul 22, 2024

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Jul 22, 2024

Improve/fix stub, stub tests + single snapshot + snapshot versions:

  • fastqc
  • qualimap/bamqc
  • qualimap/bamqccram
  • qualimap/rnaseq
  • picard/markduplicates
  • samtools/flagstat
  • samtools/idxstats
  • samtools/index
  • samtools/sort
  • samtools/stats
  • star/align
  • star/genomegenerate
  • stringtie/stringtie
  • ucsc/bedgraphtobigwig

Updating snapshot for depending subworkflows:

  • bam_dedup_stats_samtools_umitools
  • bam_markduplicates_picard
  • bam_sort_stats_samtools
  • fastq_fastqc_umitools_fastp
  • fastq_fastqc_umitools_trimgalore

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is just changes to the tests and a few more stub tests, no actual changes to the stub generation?

@maxulysse
Copy link
Member Author

This looks like it is just changes to the tests and a few more stub tests, no actual changes to the stub generation?

Yes, I think I did update the actual stub generations in previous PRs

@maxulysse maxulysse requested a review from dmarron as a code owner July 22, 2024 15:48
@maxulysse
Copy link
Member Author

Hitting:

WARNING: Your kernel does not support CPU shares or the cgroup is not mounted. Shares discarded.
touch: .command.trace: Permission denied

Usually a relaunch does the trick, but I've retriggered enough time, and really want to merge this, so I'll be force merging this one.

@maxulysse maxulysse merged commit 46eca55 into nf-core:master Jul 22, 2024
113 of 115 checks passed
@maxulysse maxulysse deleted the stubs_rnaseq_ix branch July 22, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants