Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2: stub, stub test, improved tests and meta.yml #4572

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

leoisl
Copy link
Contributor

@leoisl leoisl commented Dec 11, 2023

This PR improves the aria2 module by adding stub, stub test, improved tests and meta.yml.

@leoisl leoisl requested a review from JoseEspinosa as a code owner December 11, 2023 19:47
@leoisl leoisl requested a review from mashehu December 14, 2023 17:45
@leoisl leoisl added this pull request to the merge queue Dec 14, 2023
Merged via the queue into nf-core:master with commit 7d0ccc0 Dec 14, 2023
11 checks passed
@leoisl leoisl deleted the aria2 branch December 14, 2023 18:11
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Dec 21, 2023
* fix: add stub section and improve tests for aria2

* fix: improve metadata for aria2, removing a linting warning

* fix: improving how stub test results is asserted

* fix: adding output.meta back to meta.yml

* fix: now snapshotting the whole process.out even in the stub test
lrauschning pushed a commit to lrauschning/modules that referenced this pull request Jan 17, 2024
* fix: add stub section and improve tests for aria2

* fix: improve metadata for aria2, removing a linting warning

* fix: improving how stub test results is asserted

* fix: adding output.meta back to meta.yml

* fix: now snapshotting the whole process.out even in the stub test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants