Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to action comment on pytest-workflow runs #4151

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add call to action comment on pytest-workflow runs #4151

merged 3 commits into from
Nov 22, 2023

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Oct 18, 2023

Opinions on the wording here? I don't love it currently, but I feel if we don't ask no one ever will.

Where's the docs? Do we have an issue to update the modules create?(Made one)

Closes #4055

@edmundmiller edmundmiller requested a review from a team as a code owner October 18, 2023 10:27
@edmundmiller edmundmiller requested review from adamrtalbot, ewels and a team and removed request for ewels October 18, 2023 10:27
@edmundmiller edmundmiller self-assigned this Oct 18, 2023
@maxulysse
Copy link
Member

I'm happy with that, but I think we'd need to add a link to website with docs on how we do things

@edmundmiller edmundmiller requested review from a team and removed request for a team October 18, 2023 10:33
@edmundmiller
Copy link
Contributor Author

nf-core/website#2050 If someone could point to the work/PR on this issue then.

Co-authored-by: Adam Talbot <[email protected]>
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not before we have docs on the website

@edmundmiller
Copy link
Contributor Author

Alright waiting on nf-core/website#2050

.github/workflows/test.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go for me, if we point to the conversion docs

@mashehu mashehu enabled auto-merge November 22, 2023 09:14
@mashehu mashehu disabled auto-merge November 22, 2023 10:00
@mashehu mashehu merged commit 26dadb1 into master Nov 22, 2023
60 of 153 checks passed
@mashehu mashehu deleted the help branch November 22, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Status: Done
Development

Successfully merging this pull request may close these issues.

Add a bot comment when pytest-workflow tests run
6 participants