Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/components/dropdown/__tests__/dropdown.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,36 @@ describe("Dropdown", () => {
expect(menu).toBeFalsy();
});

it("should not open on disabled dropdown", () => {
const wrapper = render(
<Dropdown isDisabled>
<DropdownTrigger>
<Button data-testid="trigger-test">Trigger</Button>
</DropdownTrigger>
<DropdownMenu aria-label="Actions">
<DropdownItem key="new">New file</DropdownItem>
<DropdownItem key="copy">Copy link</DropdownItem>
<DropdownItem key="edit">Edit file</DropdownItem>
<DropdownItem key="delete" color="danger">
Delete file
</DropdownItem>
</DropdownMenu>
</Dropdown>,
);

let triggerButton = wrapper.getByTestId("trigger-test");

expect(triggerButton).toBeTruthy();

act(() => {
triggerButton.click();
});

let menu = wrapper.queryByRole("menu");

expect(menu).toBeFalsy();
});

it("should not select on disabled item", () => {
const onSelectionChange = jest.fn();
const wrapper = render(
Expand Down
9 changes: 9 additions & 0 deletions packages/components/dropdown/stories/dropdown.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,15 @@ export const DisabledKeys = {
},
};

export const DisabledTrigger = {
render: Template,

args: {
...defaultProps,
isDisabled: true,
},
};

export const SingleSelection = {
render: SingleSelectionTemplate,

Expand Down
2 changes: 1 addition & 1 deletion packages/components/popover/src/popover-trigger.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const PopoverTrigger = forwardRef<"button", PopoverTriggerProps>((props, _) => {
}, [children]);

const {onPress, ...rest} = useMemo(() => {
return getTriggerProps(mergeProps(child.props, otherProps), child.ref);
return getTriggerProps(mergeProps(otherProps, child.props), child.ref);
}, [getTriggerProps, child.props, otherProps, child.ref]);

// validates if contains a NextUI Button as a child
Expand Down