Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

augur traits does not export mugration models into the same output directory as traits JSON #541

Closed
huddlej opened this issue Apr 18, 2020 · 0 comments · Fixed by #544
Closed
Labels
bug Something isn't working easy problem Requires less work than most issues good first issue A relatively isolated issue appropriate for first-time contributors please take this issue Extra attention is needed priority: low To be resolved after high and moderate priority issues

Comments

@huddlej
Copy link
Contributor

huddlej commented Apr 18, 2020

Current Behavior

Running augur traits as follows outputs treecountry.mugration_model.txt and treeregion.mugration_model.txt files in the expected/ subdirectory instead of the same directory where the traits.json is written out.

augur traits \
  --tree expected/tree.nwk \
  --weights config/trait_weights.csv \
  --metadata expected/metadata.tsv \
  --output-node-data traits.json \
  --columns country region \
  --sampling-bias-correction 3 \
  --confidence

This issue results from using the input tree's name as an output prefix for the mugration models instead of the output prefix for the traits file itself.

Expected behavior

All implicit outputs from an augur command should be written to the same directory as the explicit output(s) unless there are explicit options to do otherwise (e.g., a mugration model output prefix).

Possible solution

Determine the full output path of the traits JSON prior to outputting the mugration models and use the prefix of this output path instead of the tree's prefix.

@huddlej huddlej added bug Something isn't working priority: low To be resolved after high and moderate priority issues good first issue A relatively isolated issue appropriate for first-time contributors easy problem Requires less work than most issues please take this issue Extra attention is needed labels Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy problem Requires less work than most issues good first issue A relatively isolated issue appropriate for first-time contributors please take this issue Extra attention is needed priority: low To be resolved after high and moderate priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant