Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow generation of unique node ids in export #1068

Closed
corneliusroemer opened this issue Oct 21, 2022 · 2 comments
Closed

ENH: Allow generation of unique node ids in export #1068

corneliusroemer opened this issue Oct 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

Context

When sharing a tree, it's often useful to be able to point viewers to an exact node.

Node zooming of Auspice only works if there's a unique label or combination of labels that identifies the node in question.

It'd be nice if there was the option to generate such unique labels for a given Auspice tree in Augur.

This is one example implementation that does this: https://github.com/corneliusroemer/nextstrain-deploy/blob/main/deploy.py#L17-L25

Alternatives are to have Auspice generate the unique label on the fly, by hashing some property of an internal node.

Maybe it'd be better to generate this in Auspice and allow users to choose whether they want to share using that hash or not.

I think one reason we don't generate such a hash is that it would not be stable across trees. And we prefer to have stability across rebuilds.

We could solve this by having two hierarchies of zoom labels: a) (ideally) reproducible, based on mutations, and other branch labels, and b) a lower priority hash that is a fallback and works only on the exact tree.

@corneliusroemer corneliusroemer added the enhancement New feature or request label Oct 21, 2022
@tsibley
Copy link
Member

tsibley commented Oct 21, 2022

I believe this is a duplicate of nextstrain/auspice#1036, where there was much discussion and general consensus on a solution for this. No implementation yet, however.

@victorlin victorlin closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2022
Repository owner moved this from New to Done in Nextstrain planning (archived) Nov 2, 2022
@corneliusroemer
Copy link
Member Author

Thanks @tsibley for linking the previous discussion.

Both solutions require changes to augur export so it would make sense to have an issue in Augur for this - not (just) Auspice or transfer that issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants