Checkout remote tag if checkout remote branch fails #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
requested changes
Oct 4, 2023
Signed-off-by: Ben Sherman <[email protected]>
pditommaso
reviewed
Oct 30, 2023
pditommaso
reviewed
Nov 2, 2023
modules/nextflow/src/main/groovy/nextflow/scm/AssetManager.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Paolo Di Tommaso <[email protected]>
bentsherman
commented
Nov 10, 2023
modules/nextflow/src/main/groovy/nextflow/scm/AssetManager.groovy
Outdated
Show resolved
Hide resolved
Co-authored-by: Ben Sherman <[email protected]> Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4246
checkoutRemoteBranch()now falls back to checking for remote tag if the branch checkout fails (which it will if the revision is a tag).For some reason though, the returned ref is null, even though a tag is considered a ref, so the message will say "checkout at null: revision [abcdef]". Not sure how to deal with that.
To test: