Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link bubble: click outside no longer closes the bubble #5539

Closed
Tracked by #5442
mejo- opened this issue Mar 20, 2024 · 0 comments · Fixed by #5691
Closed
Tracked by #5442

Link bubble: click outside no longer closes the bubble #5539

mejo- opened this issue Mar 20, 2024 · 0 comments · Fixed by #5691
Assignees
Labels
Milestone

Comments

@mejo-
Copy link
Member

mejo- commented Mar 20, 2024

Describe the bug
It's no longer possible to close the link bubble by clicking outside of it. Only clicking on another position in the document closes it now. This is particularly annoying in read-only mode when the document consists of only one link (or has very few lines afterwards).

To Reproduce
Steps to reproduce the behavior:

  1. Create a document, add a link, open the link bubble by clicking on the link
  2. Click anywhere outside the editor container and see that the link bubble doesn't close

Expected behavior
Clicking anywhere outside the link bubble should close it.

This is a regression from #5529, cc @max-nextcloud.

@mejo- mejo- added bug Something isn't working 1. to develop regression ux labels Mar 20, 2024
@mejo- mejo- added this to the Nextcloud 29 milestone Mar 20, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 20, 2024
@mejo- mejo- mentioned this issue Mar 20, 2024
11 tasks
@max-nextcloud max-nextcloud moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Apr 15, 2024
@max-nextcloud max-nextcloud self-assigned this Apr 15, 2024
@max-nextcloud max-nextcloud moved this from 🏗️ In progress to 👀 In review in 📝 Office team Apr 17, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants