Skip to content

Conversation

@sowjanyakch
Copy link
Contributor

Resolve #5568

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot 2025-11-25 at 10 17 47 Screenshot 2025-11-25 at 10 13 57

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5585.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

@sowjanyakch sowjanyakch self-assigned this Nov 25, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 25, 2025
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Nov 27, 2025

Issue but I am not sure it is easy to solve...

Incoming no preview but icon fallback
Screenshot_20251127_153254

Same for outgoing
Screenshot_20251127_153347

Can't tell if a layered drawable would work, also expect the loading spinner has the same issue but harder to spot given it is not permanently shown. The issue is basically that the image view of the preview seems stretched based on the outer container element via the flex-box logic.

@sowjanyakch sowjanyakch marked this pull request as draft December 2, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a button indicating a video

3 participants