Skip to content

Allow to opt-out of keyboard shortcuts #7563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickvergessen opened this issue Jul 11, 2022 · 5 comments · Fixed by #7936
Closed

Allow to opt-out of keyboard shortcuts #7563

nickvergessen opened this issue Jul 11, 2022 · 5 comments · Fixed by #7936

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Jul 11, 2022

There are keyboard shortcuts for activating different functions in the Talk app. Shortcuts such as these can interfere with shortcuts used by some assistive technologies.

To follow the WCAG-requirements, and make sure that this can work with these assistive technologies the best option would be to give an option to turn off these shortcuts.

You could also make it so the shortcuts are only active when the user has focused on the area they affect.

We also recommend that you test to make sure the shortcuts don’t interfere with screen reader commands in particular (NVDA, Jaws, Orca).

Suggested solution

  • Give an option to turn off keyboard shortcuts
  • Set them to only be active when the user is in the area they affect
  • Test so the shortcuts don’t interfere with screen reader commands
@marcoambrosini
Copy link
Member

Shouldn't this be an override that affects all apps in the accessibility settings?

@nickvergessen
Copy link
Member Author

Could also see it like that. @ChristophWurst did you implement something in the mail app already?

@nickvergessen
Copy link
Member Author

https://www.w3.org/TR/WCAG21/#character-key-shortcuts

Problem is especially shortcuts without ctrl/alt or another modifier.

So especially our mute (M), video on/off (V), push-to-talk (space), ...

@nickvergessen
Copy link
Member Author

Server PR for the global setting:

@nickvergessen
Copy link
Member Author

nickvergessen commented Sep 14, 2022

Server PR for a global setting to opt out of keyboard shortcuts to satisfy accessibility is in:

Method to check: OCP.Accessibility.disableKeyboardShortcuts()

If that is true the app(s) must not register ANY shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants