Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bots): Event based bots #14160

Merged
merged 3 commits into from
Jan 21, 2025
Merged

feat(bots): Event based bots #14160

merged 3 commits into from
Jan 21, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jan 20, 2025

🛠️ API Checklist

Steps

  • Expose moderator rank
  • Handle when enabling and listing the bots
  • Handle new feature in InstallBot event

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen force-pushed the feat/noid/event-based-bots branch from 834947b to fda4978 Compare January 21, 2025 10:35
@@ -19,7 +19,7 @@ Install a new bot on the server
|---|---|---|---|---|---|
| `--output` | Output format (plain, json or json_pretty, default is plain) | yes | no | no | `'plain'` |
| `--no-setup` | Prevent moderators from setting up the bot in a conversation | no | no | no | `false` |
| `--feature\|-f` | Specify the list of features for the bot - webhook: The bot receives posted chat messages as webhooks - response: The bot can post messages and reactions as a response - none: When all features should be disabled for the bot | yes | yes | yes | *Required* |
| `--feature\|-f` | Specify the list of features for the bot - webhook: The bot receives posted chat messages as webhooks - response: The bot can post messages and reactions as a response - event: The bot reads posted messages from local events - none: When all features should be disabled for the bot | yes | yes | yes | *Required* |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it also do something with the events? Maybe that can be mentioned in the docs?

Suggested change
| `--feature\|-f` | Specify the list of features for the bot - webhook: The bot receives posted chat messages as webhooks - response: The bot can post messages and reactions as a response - event: The bot reads posted messages from local events - none: When all features should be disabled for the bot | yes | yes | yes | *Required* |
| `--feature\|-f` | Specify the list of features for the bot - webhook: The bot receives posted chat messages as webhooks - response: The bot can post messages and reactions as a response - event: The bot reads posted messages from local events and acts on the predefined triggers (if any) - none: When all features should be disabled for the bot | yes | yes | yes | *Required* |

Something like that maybe?

@nickvergessen nickvergessen merged commit 422faeb into main Jan 21, 2025
153 checks passed
@nickvergessen nickvergessen deleted the feat/noid/event-based-bots branch January 21, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants