Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useDocumentTitle): skip asterik for normal messages in archives #14101

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jan 10, 2025

☑️ Resolves

  • Archive a conversation and go to a different tab
  • Send a normal message in the archived conversation from another user
    -> you see an asterik in the doc title, you come back, you see no change in your main conversations list and no blue bubble in archived conversations button

showArchivedConversationsBubble() {
return this.archivedConversationsList
.some(conversation => hasUnreadMentions(conversation) || hasCall(conversation))
},

🏁 Checklist

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, nice work!

@Antreesy
Copy link
Contributor

/backport to stable30

@DorraJaouad DorraJaouad merged commit 07ebe85 into main Jan 10, 2025
50 checks passed
@DorraJaouad DorraJaouad deleted the fix/noid/document-title-archived-conversation branch January 10, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants