Payload for should-refresh-conversations
event from signaling server
#12623
Labels
Milestone
should-refresh-conversations
event from signaling server
#12623
A
room
signaling message withroomid: ""
is sent by the signaling server when the current participant leaves a room (as a response to the message sent by the client, note thatshould-refresh-conversations
is not directly triggered by_doLeaveRoom
as seems to be implied from the second commit message, it is indirectly triggered). However, that message can be sent by the signaling server too to the active participants of a room if that room is deleted.If the participant is a registered user the client will also receive a
roomlist
signaling message withtype: "disinvite"
, which will cause a redirection tospreed/not-found
. However, if the particiant is a guest no other signaling message will be received to notify the client about the current room being deleted.Due to that, if
should-refresh-conversations
is not emitted when aroom
signaling message withroomid: ""
is sent by the signaling server the UI is not immediately updated for guests when public conversations are deleted (although it will be updated at most after 30 seconds, but that smells like legacy code that might be cleaned at some point).Similarly, if a video verification conversation is deleted by the moderator without even joining the conversation the UI for the guest will never reflect that the conversation is deleted. If the moderator joins the conversation and then leaves (which automatically deletes the conversation) it will, but only because when the moderator leaves a
roomlist
message withtype: "update"
will be sent, which will also cause the conversation to be fetched again (and as the conversation is automatically deleted it will no longer exist once the request reaches the server, so the UI will be properly updated on the response).Would it be possible to emit
should-refresh-conversations
even whenroomid: ""
but ignore the event in those places in which an update is not needed in that case? Or maybe emit a different event whenroomid: ""
that could be explicitly listened to if needed?Originally posted by @danxuliu in #12557 (review)
The text was updated successfully, but these errors were encountered: