Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NcModal): don't close modals if they were filled #11941

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(NcModal): don't close modals if they were filled #11941

merged 1 commit into from
Mar 27, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix accidental closing by clicking outside of modals, which require a decent investment of time to fill

🖌️ UI Checklist

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it

@Antreesy Antreesy added this to the 💞 Next RC (29) milestone Mar 27, 2024
@Antreesy Antreesy requested a review from DorraJaouad March 27, 2024 09:46
@Antreesy Antreesy self-assigned this Mar 27, 2024
@Antreesy Antreesy merged commit 58f6d61 into main Mar 27, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/keep-filled-modals branch March 27, 2024 10:27
This was referenced Mar 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@Antreesy Antreesy

Labels
3. to review enhancement feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v19.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Antreesy @nickvergessen