-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji picker in the chat #1130
Comments
See here for my suggestion to this problem: nextcloud/server#10293 Then we could standardize the look of it across platforms and @jancborchardt seems to agree. |
Just did a pilot and this came up as one of the 2 missing features on mobile apps. |
So @juliushaertl implemented the emoji picker for the Social app using Twemoji (which we want to use globally). The pull request is at nextcloud/social#18, and maybe Julius has some additional insight there. The look is great, and position at the right inside of the input field too. We could standardize it like that @nextcloud/designers |
So blocked by #1347 |
We also should ship the emoji assets with the server so we don't have the images duplicate in every app. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I'd be interested to work on this but I fear I would need some guidance. Where would this emoji picker go? A new Vue component in nextcloud-vue which can be re-used by spreed but also for comments etc? |
cc @ma12-co @skjnldsv @juliushaertl for guidance there. I would assume a Vue component indeed, because we do have an emoji picker in the Social app already cc @violoncelloCH |
Hi @simonspa, thank you for considering this :) |
After some discussion in the chat it looks like https://www.npmjs.com/package/emoji-mart-vue-fast is the most promising candidate. I'll go ahead and play a bit with it and see where I get with it. |
License: BSD-3-Clause |
Certainly far from being an expert, but this is what GNU has to say about it:
https://www.gnu.org/licenses/license-list.html It would be more of a problem in the reverse case (NC being BSD, component being *GPL) I guess. |
BSD is one of the most permissive licences. We can definitely use it. |
Confirmed by @schiessle we can use it |
at least the original implementation of the emoji picker in social was done by @juliushaertl ... there we use vue-emoji-picker -- see here: https://github.com/nextcloud/social/blob/52398387c5f062a34dcdd379243c6589aa89f47f/src/components/Composer.vue#L55-L81 |
Yes, we had a quick chat about it this morning. It will be added in the |
@simonspa any progress? :) |
Yes, some, I started writing the component but then didn't have enough time to finish it. I might have the next days though - and I might hang around in the community chat to ask noob questions about Vue. :) |
@simonspa Could you give me quick status update on the emoji picker? I need one for nextcloud/server#21186 If you need help or have any questions, please don't hesitate to ask. :) |
Done via #3994 |
Specs are rather light.
We don't want to create a beast here, just help people with a dedicated Emoji input option.
Second step: solution how to display emojis when no emoji font is installed.
The text was updated successfully, but these errors were encountered: