Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psalm Error: lib/Share/Helper/FilesMetadataCache.php:61:19: InvalidNullableReturnType #11182

Closed
SystemKeeper opened this issue Dec 10, 2023 · 2 comments · Fixed by #11183
Closed

Psalm Error: lib/Share/Helper/FilesMetadataCache.php:61:19: InvalidNullableReturnType #11182

SystemKeeper opened this issue Dec 10, 2023 · 2 comments · Fixed by #11183
Assignees
@nickvergessen
Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Comments

@SystemKeeper
Copy link
Contributor

See CI run https://github.com/nextcloud/spreed/actions/runs/7159931810/job/19493731802?pr=11181

Error: lib/Share/Helper/FilesMetadataCache.php:61:19: InvalidNullableReturnType: The declared return type 'array{height: int, width: int}' for OCA\Talk\Share\Helper\FilesMetadataCache::getMetadataPhotosSizeForFileId is not nullable, but 'array{height: int, width: int}|null' contains null (see https://psalm.dev/144)

Error: lib/Share/Helper/FilesMetadataCache.php:77:10: NullableReturnStatement: The declared return type 'array{height: int, width: int}' for OCA\Talk\Share\Helper\FilesMetadataCache::getMetadataPhotosSizeForFileId is not nullable, but the function returns 'array{height: int, width: int}|null' (see https://psalm.dev/139)
@SystemKeeper SystemKeeper added 1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Dec 10, 2023
@nickvergessen nickvergessen self-assigned this Dec 10, 2023
@nickvergessen
Copy link
Member

Weird, at least programmatically it's not possible and I had fixed that in the PR.

@nickvergessen nickvergessen mentioned this issue Dec 11, 2023
Merged
3 tasks
@nickvergessen
Copy link
Member

Psalm update from saturday makes the difference: #11169
CS Fixer was still green: #11168

Problem is psalm was not marked required. Fixed that now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CI): Make psalm more happy about not returning null nextcloud/spreed
2 participants
@nickvergessen @SystemKeeper