Skip to content

Confusing prominent buttons on poll dialogue #10893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
blizzz opened this issue Nov 14, 2023 · 9 comments · Fixed by #11099
Closed

Confusing prominent buttons on poll dialogue #10893

blizzz opened this issue Nov 14, 2023 · 9 comments · Fixed by #11099

Comments

@blizzz
Copy link
Member

blizzz commented Nov 14, 2023

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Have a theme with warm colors
  2. Have a poll
  3. Vote on that poll
  4. Close the dialog by visual style, not reading

Expected behaviour

I shall not be confused with an destructive action i cannot undo.

Actual behaviour

vote actions buttons

When I am about to sumbit my poll the primary color and the big red end button are very similar. But because the submit button is disabled before I select the option, I see the change and survive this step.

not close poll

Then, I read the results and want to close the dialogue, so i click on the lower right button, expecting close. While I do not expect to be able to close the poll (I did not start, but am moderator), I also would expect a close button there, rather an end one.

Eventually, I cannot undo ending the poll.

While you can argue it is my fault to have an orange primary color, the styling, positioning and incorrectability of my action may be considered nevertheless.

Talk app

Talk app version: 18.0.0-beta2

Browser

Browser name: Firefox

Browser version: 119.0.1

Server configuration

Nextcloud Version: 28.0.0 beta 2

@blizzz blizzz changed the title Confusing prominent buttons Confusing prominent buttons on poll dialogue Nov 14, 2023
@nickvergessen
Copy link
Member

I guess that is a general problem with theming atm.

But yeah gets more complicated when the buttons are next too each other.

@blizzz
Copy link
Member Author

blizzz commented Nov 14, 2023

Not only with theming, as I tried to point it out. Such uncommon but decisive action could be hidden behind a ⚙️ icon or something, but not be shown by default in such dominant manner.

@DorraJaouad
Copy link
Contributor

cc @nextcloud/designers
Option1: Move "End Poll" to a 3-dot menu like it is done in Media Settings
image

Option2 : Change the button type to tertiary with no background

Option3: Move both buttons in a menu-button like this (bottom right)
image

IMO, I prefer the 3rd option as it leaves a room for scalability and also doesn't emphasize any action that causes confusion in some way. Beyond this issue, I would like to bring these points

  • Share results automatically after closing the poll should be an option
  • "Private Poll" means "keep responses anonymous" (rewording)
  • At least Moderator/Poll creator should see who voted when the poll is open (when it is not anonymous ofc)
  • Option to export results after Poll is closed ( already mentioned in a discussion)

If they are valid, I will create a new issue.

@nickvergessen
Copy link
Member

Option1: Move "End Poll" to a 3-dot menu like it is done in Media Settings

This sounds like the best option from the things still doable atm

@DorraJaouad
Copy link
Contributor

This sounds like the best option from the things still doable atm

The menu button is also doable ( NcActions )

@nickvergessen
Copy link
Member

yeah but I don't want the button to submit the poll to be that hidden.

@marcoambrosini
Copy link
Member

I think that this is us being too permissive with themes. All "error" buttons are going to look like primary with such theming colors. I don't think that hiding all of them is a workable solution.

cc @nextcloud/designers

@DorraJaouad
Copy link
Contributor

I think that this is us being too permissive with themes. All "error" buttons are going to look like primary with such theming colors. I don't think that hiding all of them is a workable solution.

cc @nextcloud/designers

We can also use the same technique as in Call button ( showing a default button text and clicking brings the menu)
image

@szaimen
Copy link
Contributor

szaimen commented Nov 30, 2023

I think the Change your vote and the Submit Vote should be clearly visible. However I would indeed hide the End Poll button in a 3-dot menu...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants