fix(bots): Add a constant for the protocol

Signed-off-by: Joas Schilling <[email protected]>

Author: nickvergessen

Diff for: lib/Command/Bot/Install.php

@@ -81,10 +81,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
 		if (!empty($input->getOption('feature'))) {
 			$featureFlags = Bot::featureLabelsToFlags($input->getOption('feature'));
-			if (str_starts_with($url, 'nextcloudapp://')) {
+			if (str_starts_with($url, Bot::URL_APP_PREFIX)) {
 				$featureFlags &= ~Bot::FEATURE_WEBHOOK;
 			}
-		} elseif (str_starts_with($url, 'nextcloudapp://')) {
+		} elseif (str_starts_with($url, Bot::URL_APP_PREFIX)) {
 			$featureFlags = Bot::FEATURE_EVENT;
 		} else {
 			$featureFlags = Bot::FEATURE_WEBHOOK + Bot::FEATURE_RESPONSE;

Diff for: lib/Model/Bot.php

@@ -23,6 +23,7 @@ class Bot {
 	public const FEATURE_LABEL_WEBHOOK = 'webhook';
 	public const FEATURE_LABEL_RESPONSE = 'response';
 	public const FEATURE_LABEL_EVENT = 'event';
+	public const URL_APP_PREFIX = 'nextcloudapp://';
 
 	public const FEATURE_MAP = [
 		self::FEATURE_NONE => self::FEATURE_LABEL_NONE,

Diff for: lib/Service/BotService.php

@@ -406,7 +406,7 @@ public function validateBotParameters(string $name, string $secret, string $url,
 			throw new \InvalidArgumentException('The provided secret is too short (min. 40 chars, max. 128 chars)');
 		}
 
-		if (!$url || strlen($url) > 4000 || !(str_starts_with($url, 'http://') || str_starts_with($url, 'https://') || str_starts_with($url, 'nextcloudapp://'))) {
+		if (!$url || strlen($url) > 4000 || !(str_starts_with($url, 'http://') || str_starts_with($url, 'https://') || str_starts_with($url, Bot::URL_APP_PREFIX))) {
 			throw new \InvalidArgumentException('The provided URL is not a valid URL');
 		}