-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(files): Load limited depth tree #47122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
enhancement
3. to review
Waiting for reviews
feature: files
performance 🚀
labels
Aug 8, 2024
Pytal
added
the
pending documentation
This pull request needs an associated documentation update
label
Aug 8, 2024
Pytal
force-pushed
the
feat/limited-depth-tree
branch
from
August 8, 2024 04:25
4dd83f8
to
9803647
Compare
Pytal
force-pushed
the
feat/limited-depth-tree
branch
2 times, most recently
from
August 8, 2024 04:43
76103bf
to
35ae859
Compare
Merged
Altahrim
approved these changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP part LGTM :)
sorbaugh
approved these changes
Aug 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
susnux
reviewed
Aug 8, 2024
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
feat/limited-depth-tree
branch
from
August 8, 2024 18:27
35ae859
to
36c23b2
Compare
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Aug 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
skjnldsv
approved these changes
Aug 8, 2024
Pytal
removed
the
pending documentation
This pull request needs an associated documentation update
label
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: files
high
performance 🚀
🍂 2024-Autumn
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Loads the folder tree at a limited depth instead of infinite depth as before which had performance issues
Requires
feat(NcAppNavigationItem): Add prop to show collapse icon nextcloud-libraries/nextcloud-vue#5940Checklist