Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure app overflow menu is rendered centered #47031

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 5, 2024

Summary

  1. Fix app menu overflow button to be centered
  2. Ensure the overflow calculation always just removed one element (incl. refactor to use @vueuse)
  3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 5, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 5, 2024
@susnux susnux mentioned this pull request Aug 5, 2024
28 tasks
@Altahrim Altahrim mentioned this pull request Aug 6, 2024
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
1. Fix app menu overflow button to be centered
2. Ensure the overflow calculation always just removed one element (incl. refactor to use `@vueuse`)
3. Ensure we use 1.5 line height for app menu, otherwise some languages look squashed under the app icon

Signed-off-by: Ferdinand Thiessen <[email protected]>
@AndyScherzinger
Copy link
Member

/compile /

Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger AndyScherzinger merged commit 4417f0f into master Aug 7, 2024
111 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/app-menu branch August 7, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants