Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webcal): only update modified and deleted events from webcal calendars #46723

Merged
merged 1 commit into from
Aug 14, 2024
Merged

feat(webcal): only update modified and deleted events from webcal calendars #46723

merged 1 commit into from
Aug 14, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 24, 2024 •
edited
Loading

Summary

Blackfire profiling comparison for an update query:
image

Checklist

@miaulalala miaulalala added 2. developing Work in progress feature: caldav Related to CalDAV internals labels Jul 24, 2024
@miaulalala miaulalala added this to the Nextcloud 30 milestone Jul 24, 2024
@miaulalala miaulalala self-assigned this Jul 24, 2024
@miaulalala miaulalala marked this pull request as draft July 24, 2024 14:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 24, 2024
View reviewed changes
apps/dav/lib/CalDAV/CalDavBackend.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php Fixed Show fixed Hide fixed
@miaulalala miaulalala force-pushed the feat/add-delta-sync-to-subscription-calendars branch from b9d52df to 2e504d8 Compare August 5, 2024 14:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
apps/dav/lib/CalDAV/CalDavBackend.php Dismissed Show dismissed Hide dismissed
apps/dav/lib/CalDAV/CalDavBackend.php Dismissed Show dismissed Hide dismissed
@miaulalala miaulalala marked this pull request as ready for review August 7, 2024 16:08
@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 7, 2024
@miaulalala miaulalala mentioned this pull request Aug 7, 2024
Merged
@Altahrim Altahrim mentioned this pull request Aug 8, 2024
Merged
@miaulalala miaulalala force-pushed the feat/add-delta-sync-to-subscription-calendars branch from 7e7c4ae to e0b4627 Compare August 8, 2024 12:36
@ChristophWurst
Copy link
Member

What does the blackfire comparison look like without md5? Does it get even better?

ChristophWurst
ChristophWurst approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 12, 2024 •
edited
Loading

What does the blackfire comparison look like without md5? Does it get even better?

md5 vs strcasecmp:
image

@miaulalala miaulalala force-pushed the feat/add-delta-sync-to-subscription-calendars branch from af04739 to c47650c Compare August 13, 2024 08:56
ChristophWurst
ChristophWurst approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

:shipit:

@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@miaulalala miaulalala force-pushed the feat/add-delta-sync-to-subscription-calendars branch from c47650c to fb94db1 Compare August 13, 2024 11:06
st3iny
st3iny approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 14, 2024
@st3iny
Copy link
Member

st3iny commented Aug 14, 2024

I ran the freeze check again and we are good.

@st3iny st3iny merged commit b8ec68d into master Aug 14, 2024
169 checks passed
@st3iny st3iny deleted the feat/add-delta-sync-to-subscription-calendars branch August 14, 2024 06:57
@tcitworld tcitworld mentioned this pull request Aug 28, 2024
Closed
@tcitworld tcitworld mentioned this pull request Nov 20, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@kesselb kesselb Awaiting requested review from kesselb

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: caldav Related to CalDAV internals performance 🚀
Projects
💌 📅 👥 Groupware team
Status: ☑️ Done
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Use Delta for subscription calendars instead of deleting and reinserting all events
3 participants
@miaulalala @ChristophWurst @st3iny