-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jQuery to a supported version #6720
Comments
The function which is dangerous is globalEval, and we fixed this method manually: Lines 1285 to 1292 in 086ce70
We should still think about updating it at some point since 2.1 seems to not get any updates anymore. |
cc @nextcloud/javascript |
This requires #4628 to be fixed first. |
When greping through the core code, thw following in 3.x deprecated methods are also used quite often, so it makes sense to update those when bumping the jquery version:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
We're on jQuery v3.7.x today. @susnux I was going to close this, but I see you labeled this for |
Just for proper tags. |
I have found that Nextcloud include jquery version 2.1.4 that have issue in this link jquery/jquery#2432
https://github.com/nextcloud/server/blob/master/core/vendor/core.js
at line 1
/*! jQuery v2.1.4 | (c) 2005, 2015 jQuery Foundation, Inc. | jquery.org/license */
Solution that is, Nextcloud should upgrade to the lasted version that was described in issue 2432
The text was updated successfully, but these errors were encountered: