[Bug]: invalid template parameters in translations prevent substitution #46326
Assignees
Labels
Comments
dvtate
added
0. Needs triage
|
Good finding, thank you 👍 Maybe that problem could be solved by adding a translation check on transifex: https://help.transifex.com/en/articles/6241794-setting-translation-checks#h_317a8b70f5 |
|
@dvtate Can you provide the list of defective placeholders? |
rakekniven
added
feature: language l10n and translations
and removed
bug
0. Needs triage
|
I pulled and re-ran the script and here's the list of invalid placeholders: list.txt I'm not sure how to check the bundles in the I used the attached python script to generate this list translation_check.py.txt |
|
My script might not be checking all the translations |
szaimen
added
0. Needs triage
|
A lot of the strings have been fixed. Could you re-run your script next week after release of NC30? |
|
@rakekniven sure, just ping me. I'm happy to contribute where I can. The script is also attached in a previous post. Would this release make the translations in |
|
@rakekniven It seems to be improving but there are still some mistakes. I would recommend making a CI to check this. |
|
I'm also still seeing the bug that originally made me post this in nextcloud 30. |
|
It was me fixing the bug one by one. No CI check needed for the future. I adapted some settings on Transifex to protect such JavaScript placeholders. Will fix the others as soon as I have some time and mood. |
My output is different to yours. Are you using |
joshtrichards
added
2. developing
Hello @dvtate , just checked your specific case and unfortunately the cause is the same as for french. For reference: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
I was uploading some files to my Nextcloud instance which I have the language set to Danish and noticed this message "{sekunder} sekunder tilbage". I assumed the translator mistakenly translated the template parameter causing it to not get substituted.
After seeing this I didn't find it in the any of the l10n/*.json files but did find it in some compiled javascript files in
dist/which seems suspicious:Why does this happen??
I also found some problems in the l10n json files. (for example)
So I threw together a script to get all the translations with fields not in the original English version.
I think we should include this script (or some better-written version of it) as a CI/unit test before releasing.
check_translations.py
Steps to reproduce
Expected behavior
Translations should probably not translate the template params
Installation method
Other Community project
Nextcloud Server version
29
Operating system
Other
PHP engine version
PHP 8.2
Web server
Nginx
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
{ "system": { "datadirectory": "***REMOVED SENSITIVE VALUE***", "logfile": "\/var\/log\/nextcloud\/nextcloud.log", "loglevel": 3, "apps_paths": [ { "path": "\/usr\/share\/webapps\/nextcloud\/apps", "url": "\/apps", "writable": false }, { "path": "\/var\/lib\/nextcloud\/apps", "url": "\/wapps", "writable": true } ], "trusted_domains": [ "localhost", "***REMOVED SENSITIVE VALUE***" ], "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***", "htaccess.RewriteBase": "\/", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "29.0.3.4", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "memcache.local": "\\OC\\Memcache\\APCu", "enable_previews": true, "enabledPreviewProviders": [ "OC\\Preview\\Movie", "OC\\Preview\\PNG", "OC\\Preview\\JPEG", "OC\\Preview\\GIF", "OC\\Preview\\BMP", "OC\\Preview\\XBitmap", "OC\\Preview\\MP3", "OC\\Preview\\MP4", "OC\\Preview\\TXT", "OC\\Preview\\MKV", "OC\\Preview\\AVI", "OC\\Preview\\mov", "OC\\Preview\\Image" ], "maintenance": false, "theme": "", "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg", "memories.vod.ffprobe": "\/usr\/bin\/ffprobe", "memories.vod.path": "\/var\/lib\/nextcloud\/apps\/memories\/bin-ext\/go-vod-amd64", "memories.vod.disable": false, "memories.exiftool_no_local": true, "memories.db.triggers.fcu": true } }List of activated Apps
No response
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
I have installed nextcloud from the Arch Linux repos
The text was updated successfully, but these errors were encountered: