-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mime type icons and icons in "New" menu #44340
Comments
Just FYI @tobiasKaminsky @juliushaertl @sorbaugh we had to adjust the colors of 2 icons:
Considering this is also used in the file list and grid view (and in the widgets) and black this would be very dark then, we will keep it grey.
This fulfills the proper 3:1 contrast requirement and works in both light and dark theme. |
nextcloud/text#5540 for the text side. |
Wouldn't this than also apply to the file listing, so the general mime type icon if there is no preview? And if so wouldn't this also lead to the need to adapt all "grey" mimetype icons (!) which we would want to prevent atm since that change is way larger to implement and should than be moved to v30 in my opinion. (or we just do it for the text mime type, than it would be okay) |
Noticed this in the rendering of the mimetype icons (e.g. in the sidebar) which uses a background-image url and doesn't support CSS variables so I used the same grey as before |
How to use GitHub
we aim to have the icons updated for v29, the remaining parts can be ignored or implemented given the 29-timebox
Upload folders: drive-folder-upload in(New entry pushed to 30)--color-primary-element
Folder: folder in(New design with headings pushed to 30)--color-primary-element
--color-text-maxcontrast
#49abea
#9abd4e
#f0965f
#b39114
The text was updated successfully, but these errors were encountered: