-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.2.0 RC2] Autofocus and cursor pointer #827
Comments
resolved in 1.3 |
Em. I think I dreamt about that. Still open. |
I changed the link for creating a public share to a button. Fits better to an action like this IMHO. |
I tried different approches, but I can't get the focus on this input field. Anyone who has a solution? |
I can have a look at this tomorrow |
It should work here: polls/src/js/components/VoteTable/VoteHeaderPublic.vue Lines 119 to 128 in f878de9
But I get a JS error:
Calling I also tried to do this via a directive, but I get the same error. I guess, the modal component rendering is not ready, when calling from mounted(). Maybe @skjnldsv can explain, if you find no way. |
Problem is the watch: {
userName: function() {
...
},
'poll.id': function(newValue) {
this.setFocus()
}
},
mounted() {
// removed this.setFocus()
}, @dartcafe Do you already have a branch or something for this issue or should I fix it? |
https://github.com/nextcloud/polls/tree/publicLinkCursor adresses the other issue (pointer cursor). I also added a custom button component there. |
Ah, yes. I had some also, so I used v-show in some places because of that. |
@v1r0x I wanted to test your solution and already applied it to the branch. Works perfectly 👍 Didn't want to rush things, but I was curious. |
I tested the new 1.2.0 RC2. It is very good. But I have twi minimal enhancements.
If I create a public link to share the plus icon is not a pointer cursor:
If I visit the shared link the autofocus is not on the username textarea:
The text was updated successfully, but these errors were encountered: