Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owner should be able to remove entries #248

Closed
eraelpeha opened this issue Nov 19, 2017 · 13 comments
Closed

Owner should be able to remove entries #248

eraelpeha opened this issue Nov 19, 2017 · 13 comments

Comments

@eraelpeha
Copy link

It would be a great enhancement if the owner of a poll has the ability to delete single result lines from a poll (in case of test / multiple / fake entries).

@dartcafe dartcafe added this to the backlog milestone Nov 21, 2017
@dartcafe
Copy link
Collaborator

dartcafe commented Nov 21, 2017

I will think over it. But it should be reproducable for other participants. For example mark them as invalid...

@Mannshoch
Copy link

Maybe an option to to chose to show them as "removed" or simply remove an entry without information.
At moment I remove entries direct in the database.

@jancborchardt
Copy link
Member

Just had the same case, where a participant mistakenly entered their info twice. It should be simply possible to remove submissions. Sure, we can mark them as "Removed" and list them on the bottom. @dartcafe

@japso
Copy link

japso commented Jan 2, 2019

I strongly support the addition of this feature.
In my opinion,

@Mannshoch
Copy link

* there is no need for displaying removed participants (poll-owner and admin are trustworthy)

Maybe only list them as removed for the admin

@japso
Copy link

japso commented Jan 3, 2019

Personally, I do not see any advantage in displaying removed participants (and their votes?). Could you explain to me how this is meaningful in your use-case?

If the displaying of removed participants together with their votes is something others consider useful, I'd very much prefer an option for the owner/creator of a poll and any user in the admin group to hide participants together with their votes (= poll entries):

  • poll entry not hidden: poll entry visible for all users viewing the poll, poll entry is counted towards the total number of yes/nos of a vote option
  • poll entry hidden: UI: poll entry is shown as inactive for poll owner/creator and any user in the admin group and still shown at the same place within the table of votes; UI: poll entry is not visible for regular users viewing the poll; poll entry is not taken into account for calculating the total number of yes/nos of a vote option

This should be fairly simple to implement:

  • you introduce a boolean parameter for every poll entry
  • this boolean parameter has to be evaluated at certain points (UI, total number of yes/no etc.)

@jancborchardt
Copy link
Member

Let’s not get distracted by details. :) As always, we need to tackle it step by step:

First is the simple ability to remove entries. They don’t need to show up anymore.

Then afterwards we can still see if it’s needed to show them greyed out or so (not counting towards the total of course).

@japso
Copy link

japso commented Jan 5, 2019

Thank you @jancborchardt , I fully agree with you. Removing entries is the priority here.

@tbhunderbird
Copy link

Any updates on when it might become available?

@dartcafe
Copy link
Collaborator

dartcafe commented Mar 4, 2019

Standard answer: When it's ready.

Work on vue migration is in progress. After that, it could be possible to be on the todo list.

@MacGulliver
Copy link

Any news as of now?

@thamvmk
Copy link

thamvmk commented Oct 8, 2019

Yeah, anyone working on this feature?

@dartcafe dartcafe modified the milestones: backlog, next Jan 12, 2020
@dartcafe dartcafe removed this from the next milestone Jan 12, 2020
@dartcafe
Copy link
Collaborator

#736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants