Autofill and additional features #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
binsky08
commented
Feb 26, 2021
•
binsky08
commented
- Mark compromised credentials
- Add URL copy and open button
- Add app start password option based on the android user authentication (partly solves Password master on open app #67)
- Enable code optimization in the C compiler options to speed up the C based encryption
- Use a random number generator for the salt length
- Do not reload the whole vault after adding, editing or deleting a credential
- Move double RequestParams generation logic of Credential.java to an own function
- Remove Java bouncycastle crypto library
- Implement Android autofill feature (requires at least Android API level 26)
- based on the work of https://github.com/HahUK/passman-android/tree/feature-android-autofill-and-gen-additions
- solves Android Oreo Autofill #50 (autofill issue)
- autofill "automatic mode" requires the app to run in the background with unlocked vault, uses the opened vault
- "offline mode" saves a selected vault offline (encrypted), but requires a saved vault password to run completely independently in the background
- hopefully fixed bug with unset compromised field
- remove debugAndToast functions from generalUtils
- add custom response handlers
New menu options added: 1.) Lock Vaults - lock all unlocked vaults 2.) Clear Saved Vault Creds - remove saved vault creds 3.) Enable Autofill - Helps user enable the autofill service UI now shows loading screen whilst loading in Vaults from the API.
Looking to handle more fields and applications.
Looking to handle more fields and applications. Addition of notification which can copy the credential entry to the clipboard. Notification fires on Credential long click.
Fix bogus? API responses from POST and PATCH to credentials endpoint
Improvements to Notification handling. Cody Tidy Up
…utofill-and-gen-additions
…github.com/hahuk/passman-android into feature-android-autofill-and-gen-additions
…hub.com/hahuk/passman-android into feature-credential-display-autoLink-url
…github.com/hahuk/passman-android into feature-android-autofill-and-gen-additions Signing Commit
…github.com/hahuk/passman-android into feature-android-autofill-and-gen-additions
Bring up to date with nextcloud/passman-android
…s unsupported. Get the IV directly from the cipher object instead.
…github.com/hahuk/passman-android into feature-credential-display-autoLink-url # Conflicts: # app/src/main/java/es/wolfi/app/passman/CredentialDisplay.java # app/src/main/res/layout/fragment_credential_display.xml
Feature credential display auto link url
…man-android into additional_features-1 Signed-off-by: binsky08 <[email protected]>
…additions' into autofill
Signed-off-by: binsky08 <[email protected]>
Signed-off-by: binsky08 <[email protected]>
Signed-off-by: binsky08 <[email protected]>
…e vault Signed-off-by: binsky08 <[email protected]>
Signed-off-by: binsky08 <[email protected]>
…er domains) Signed-off-by: binsky08 <[email protected]>
Signed-off-by: binsky08 <[email protected]>
…lUtils Signed-off-by: binsky08 <[email protected]>
Signed-off-by: binsky08 <[email protected]>
animalillo
reviewed
Apr 11, 2021
| Snackbar.make(view, R.string.successfully_updated, Snackbar.LENGTH_LONG) | ||
| .setAction("Action", null).show(); | ||
| assert getFragmentManager() != null; | ||
| try { |
There was a problem hiding this comment.
This code seems to be repeated a few times, wonuldn't it be better if it was moved to it's own function?
I'm not sure if it might make sense to move it to the api library or if it's too specific for that.
There was a problem hiding this comment.
what do you mean exactly?
I think its better to define the responseHandlers where they are now. They are all a bit (some more, some less) different and need custom variables from the "outer scope".
| .setAction("Action", null).show(); | ||
| assert getFragmentManager() != null; | ||
| alreadySaving = false; | ||
| try { |
There was a problem hiding this comment.
This code seems to be repeated a few times, wonuldn't it be better if it was moved to it's own function?
I'm not sure if it might make sense to move it to the api library or if it's too specific for that.
There was a problem hiding this comment.
replaced with one of the new response handlers
| progress.setCancelable(false); | ||
| progress.show(); | ||
|
|
||
| AsyncHttpResponseHandler responseHandler = new AsyncHttpResponseHandler() { |
There was a problem hiding this comment.
Could it make sense to move the API interaction to the API library on this context?
There was a problem hiding this comment.
replaced with one of the new response handlers
app/src/main/java/es/wolfi/app/passman/CustomFieldViewAdapter.java
Outdated
Show resolved
Hide resolved
… ResponseHandler implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.