-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TB 68 support #80
Comments
@oparoz @guillaumev It would be great to revive this extension. Do you know which parts have to be fixed to make it work with Thunderbird 68? |
Yes please try a update. There are near none FileLink alternatives for 68.0 |
The WebDav filelink provider module works well with TB68 and NextCloud if it can help. |
@guillaume-smo How did you set up the Webdav filelink provider? |
@gulliaume-smo: |
I agree with this request! |
I created a PR here: #82 This is in a very early stage and for now, nothing works, but help will be greatly appreciated :-) |
Will it help if I post a bounty for this? |
@ediazcomellas I think posting a bounty is always a good incentive. |
$100 added. |
@jospoortvliet Can you add this repository to the Bountysource bot? |
@e-alfred done. Sorry, I rarely manage to catch up to notifications in github :( |
Hello, |
Maybe someone can link the bountysource page here, I could not find it. |
Onwcloud addon: Github repo: Doesn't work with Nextcloud, but I've made a fork with a little patch that works with Nextcloud: |
|
Installation
or download my packed and patched addon: filelink-owncloud-patched |
Unfortunately, I have an error message "Imposible to upload to Owncloud" :-( |
Hi, thanks @josepmendoza Works fine on my side with TB68.2.2 and NC16.0.7. I'm using an app token as proposed and just had to replace the storage path to the previous /Mail-attachments/ value. |
forgot to replace /Mailattachments/ on my settings to /Mail-attachments/ |
@oparoz @guillaumev Can you merge the fixed code and release an official app? |
The owncloud version from @thosmos didn't work with my universities owncloud, but the nextcloud version from @josepmendoza works fine. The owncloud version can upload the file, but it didn't paste anything in my mail (forever spinning indicator). May I suggest adding some random numbers (?) to the file name as the old version did. So it doesn't make filename collisions if uploading the same file twice. |
I've incorporated @josepmendoza's changes and also the random file name into the published version 1.7 at https://addons.thunderbird.net/es/thunderbird/addon/filelink-provider-for-owncloud/ I have it working on both owncloud and nextcloud. I would appreciate feature requests or bugs be made at its repo https://github.com/thosmos/filelink-owncloud |
Perfect, can you share a version with the nextcloud Logos as well? |
@thosmos Awesome work, but maybe @jospoortvliet @guillaumev @oparoz can add you as a collaborator to this repository? It would be good to have this in the main repository so people can simply update their extension instead of removing the "official" one and installing another one. |
I second that, the *cloud plugin is awesome. |
Sure, go ahead. I only gave a suggestion for those who don't know where to put the money. It's still your money, so your choice 😉 |
Just wrote a review on Thunderbird's Addon Repository -- the extension is great, actually better then the official defunct addon was. Would you please share the direct link on gitlab repository you'd like to have the stars on? EDIT: Oops, the link was in the previous message. |
Bountysource tells me, that I can claim it as soon as #80 is closed as fixed. @ChristophWurst can you do that? |
@qm2k thanks a lot. The project ist here: https://gitlab.com/joendres/filelink-nextcloud |
Please ask someone of the contributors to close this ticket as I do not want to get into other people's stuff. |
It would be awesome to make *cloud the new official Thunderbird plugin for Nextcloud. Right now all links go to this deprecated repository leading people to a non-working extension. |
I'm super new to this repo. I didn't even know there was a Thunderbird plugin for Nextcloud. So excuse my basic questions but is the other one a fork of this one? What is stopping you from updating the references to the new repo (on gitlab)? |
@guillaumev @michaelletzgus @NDev8 @uli-heller would any of you have a problem with us closing this ticket so @joendres can claim the bounty? Let's proceed with closing unless one of these four contributors raises objections. Two weeks is a reasonable time frame, I guess. |
No, I started from scratchbecause the current API has nothing in common with the legacy one. |
closing is no problem for me
Am 24. Juni 2020, um 14:15, schrieb Christoph Wurst <[email protected]>:
@guillaumev @michaelletzgus @NDev8 @uli-heller would any of you have a problem with us closing this ticket so @joendres can claim the bounty?
Let's proceed with closing unless one of these four contributors raises objections. Two weeks is a reasonable time frame, I guess.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
[ { "@context": "<a href="http://schema.org">http://schema.org</a>", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "<a href="#80 (comment)">https://github.com/nextcloud/nextcloud-filelink/issues/80#issuecomment-648784307</a>", "url": "<a href="#80 (comment)">https://github.com/nextcloud/nextcloud-filelink/issues/80#issuecomment-648784307</a>", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "<a href="https://github.com">https://github.com</a>" } } ]
|
Looks like a good solution to me. |
@ChristophWurst it's been 3 weeks now. I'd be grateful if you could close the bug. TIA, @joendres |
I'm fine with closing but I cannot close it personally |
Sorry, I mentined the wrong person. @oparoz is the one to inform.
|
OK, I give up. None of the Contributor seems to be willing to close this issue. I had a brief contact with @oparoz via twitter, but he is unresponsive there too. I'd like to discuss how to close this in a way that a) makes users happy b) makes bountysource happy. But nobody answers. So this issue will be open forever, the links from nextcloud.com will point to the disfunctional Addon, Nextcloud users might find *cloud (or not), and bountysource will put the bounty in its own pocket in the end. Whatever... 🤷♂️ |
How can I help? |
I don't know, I'm just frustrated. By now I've literally spent hours to get somebody to communicate with me, who can decide and act on this project. That's more time than the bounty is worth -- just unsuccessfully trying to establish communication. Don't get me wrong: There are some people at Netxcloud, who try to be helpful. But they tell me, they can't decide. And those, they point me to, just don't communicate. So I'll stop reaching out and I'll try to forget about the whole thing. |
I am also fine with the *cloud extension. it's working without any problems. Does nobody know how to reach @oparoz for closing down this issue and force to pay out the bounties? |
The fact that you have to ask again and again is really bad. I don't know who can close the issue. But for sure, you cannot close it just because you're a contributor. Beside my name, this project says "Contributor" - probably because I proposed a pull request before - but I cannot close any issue. There is no "close issue" button. Sorry. |
I've asked for a refund of the bounty and will send it directly to @joendres once I get it back. |
I'm sorry for the frustration caused. It's holiday season and some of us are simply offline for their days off, and so have I. Thus there was no communication from us. What's left? Just closing of the ticket? |
@ChristophWurst Well, all of this:
*cloud is the right addon, the "official" seems to be deprecated. |
If you give me a link we can try to find the source at https://github.com/nextcloud/nextcloud.com to change that link to the "new" addon |
Unfortunately I retired my pledge at bountysource yesterday! I will send the bounty directly to Johannes. |
@ChristophWurst I think @joendres should know but I think those are the right links: https://addons.thunderbird.net/en-US/thunderbird/addon/filelink-nextcloud-owncloud/ |
Hello,
please add Thunderbird 68.0 support.
There are also some nice pull requests in the pipe... "Add random password generation support for each upload" would be really nice.
The text was updated successfully, but these errors were encountered: