Action menu on envelope and threads is broken

[GretaD]

Steps to reproduce

1. Go to mail app
2. Click the action menu of ann envelope or thread
3. Try to find create tasks for example, you will see the right icon, but move thread text
4. Click more actions on threads

Expected behavior

I have the order correctly

Actual behavior

Mail app version

main

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

This must be the nc/vue 8 migration. I probably tested it before rebase and squash, and something happened there. I dont see any other reason what could have happened.

@st3iny when you found this bug: #9279 were you on nc/vue 8? While bisecting this bug with action menu, i found out that your bug was shown for the first time on 0d9e4a8 commit.

[st3iny]

I tested this on main before after the nc/vue 8 update.

EDIT: I didn't see that we already merged the update.

[st3iny]

The icons and descriptions seem to be off but I have no idea why.

I only found this: nextcloud-libraries/nextcloud-vue#5178

[st3iny]

@st3iny when you found this bug: #9279 were you on nc/vue 8? While bisecting this bug with action menu, i found out that your bug was shown for the first time on 0d9e4a8 commit.

I also tested the linked issue with nc/vue v8 applied.

[GretaD]

The icons and descriptions seem to be off but I have no idea why.

I only found this: nextcloud-libraries/nextcloud-vue#5178

thats on 8.6.0, we are on 8.5.0

[st3iny]

Right, I even tried to update to 8.6.0 locally and it's still broken so it must be something else.

[ShGKme]

I didn't understand from the screenshot, is the only issue - error in the console, or something is working incorrectly?

[ShGKme]

The error in the console says, that you are passing incorrect type to NcActionButton.

Unlike NcButton where type is design variant like primary or secondary, in NcActionButton type represents the role and could be: button, submit, reset and radio, checkbox for toggle buttons.

[st3iny]

I didn't understand from the screenshot, is the only issue - error in the console, or something is working incorrectly?

The icons and button labels are rendered incorrectly and mixed up. It seems like the action buttons in the menu are not updated correctly.

For example

• "Move thread" should be "Create task"
• "Archive thread" should be "Create event"
• "Delete thread" has a plus icon
• etc.

[st3iny]

2024-01-30.19-40-05.mp4

[ShGKme]

Hmm, I cannot reproduce on master...

[ShGKme]

I can reproduce