Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-cs-fixer #46

Merged
merged 4 commits into from
Jul 26, 2017
Merged

Add php-cs-fixer #46

merged 4 commits into from
Jul 26, 2017

Conversation

sualko
Copy link
Member

@sualko sualko commented Jul 26, 2017

fix #43

@sualko sualko force-pushed the add-php-cs-fixer branch from 29dedd0 to 02a8dd6 Compare July 26, 2017 14:01
@codecov
Copy link

codecov bot commented Jul 26, 2017

Codecov Report

Merging #46 into master will increase coverage by 0.4%.
The diff coverage is 61.24%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #46     +/-   ##
========================================
+ Coverage     69.59%   70%   +0.4%     
  Complexity      229   229             
========================================
  Files            27    27             
  Lines           786   800     +14     
========================================
+ Hits            547   560     +13     
- Misses          239   240      +1
Impacted Files Coverage Δ Complexity Δ
lib/Settings/Admin.php 0% <0%> (ø) 5 <5> (ø) ⬇️
lib/RawRequest.php 0% <0%> (ø) 1 <1> (ø) ⬇️
lib/rosterpush.php 0% <0%> (ø) 7 <7> (ø) ⬇️
lib/command/refreshroster.php 0% <0%> (ø) 4 <4> (ø) ⬇️
lib/hooks.php 0% <0%> (ø) 9 <9> (ø) ⬇️
lib/stanzalogger.php 0% <0%> (ø) 4 <4> (ø) ⬇️
lib/Settings/Section.php 0% <0%> (ø) 5 <5> (ø) ⬇️
lib/db/iqrosterpush.php 0% <0%> (ø) 1 <1> (ø) ⬇️
lib/dblock.php 100% <100%> (ø) 3 <3> (ø) ⬇️
lib/TimeLimitedToken.php 100% <100%> (ø) 6 <6> (ø) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed15bf...fcc9b7c. Read the comment docs.

@sualko sualko merged commit 788efe3 into master Jul 26, 2017
@sualko sualko deleted the add-php-cs-fixer branch July 26, 2017 14:20
@LEDfan
Copy link
Member

LEDfan commented Jul 29, 2017

Nice! Is there are reason why the 'braces' => ['position_after_functions_and_oop_constructs' => 'same'], was not included? I personally prefer that style and Nextcloud is using it too (nextcloud/server@c36da2c#diff-8b6c0c683d533f32b31ce28cee1bd3e6R15)

@sualko
Copy link
Member Author

sualko commented Jul 31, 2017

I know, but it throw an error and a short search showed that this is now handled by the PSR2 rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add php-cs-fixer to have same code style as NC server
2 participants