Resource is sometimes needed now (e.g. in presence) fixes presence #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1f167b882be30520b297708b969f, fixes presence
|
Thanks for taking care of this. |
LEDfan
added a commit
that referenced
this pull request
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presence wasn't working anymore in the latest release (see user report https://help.nextcloud.com/t/ojsxc-online-status-of-users-not-visible-also-no-user-information-loadable/13184)
I'm quite sure this is caused since this change jsxc/jsxc@ac55184, because before this PR the internal XMPP server didn't send any resource so the else was triggered and now it isn't.
I think the best solution is to patch this on the server, especially if this is more XMPP compatible.
@sualko the user is asking for a time frame to release these two PR's (https://help.nextcloud.com/t/ojsxc-online-status-of-users-not-visible-also-no-user-information-loadable/13184/3), do you have any idea? Thanks :)