diff --git a/.changelog/current/2461-fix-changelog-checker.md b/.changelog/current/2461-fix-changelog-checker.md new file mode 100644 index 000000000..3452d7e33 --- /dev/null +++ b/.changelog/current/2461-fix-changelog-checker.md @@ -0,0 +1,2 @@ +# Fixed +- Prevent failure of changlog builder when parsing dependabot PRs without explicit changelog stub diff --git a/.github/workflows/pull-checks.yml b/.github/workflows/pull-checks.yml index 5fafb5fd0..a9dfc4381 100644 --- a/.github/workflows/pull-checks.yml +++ b/.github/workflows/pull-checks.yml @@ -97,13 +97,15 @@ jobs: echo "### No changelog was needed" echo "" echo "No changelog entry was found so far." - echo "This is okay, as no files have been modified that would require a changelog entry." - echo "You might consider if adding a changelog entry would be benefical as significant changes have been made." + echo -n "This is okay, as no files have been modified that would require a changelog entry. " + echo -n "You might consider if adding a changelog entry would be benefical as significant changes have been made. " + echo 'The changelog should be in a file starting with `.changelog/current/${{ github.event.number }}-`.' } > $GITHUB_STEP_SUMMARY fi if: ${{ steps.diff.outputs.num_lines == 0 }} - name: Install Python package run: pip install --user virtualenv pipenv + if: ${{ steps.diff.outputs.num_lines != 0 }} - name: Test creation of changelog run: | if [ -n "$RUNNER_DEBUG" ] @@ -123,6 +125,7 @@ jobs: python -m changelog_builder --token token --ci --pr ${{ github.event.number }} ../../.changelog/current/* 2>&1 echo '```' } >> $GITHUB_STEP_SUMMARY + if: ${{ steps.diff.outputs.num_lines != 0 }} todo-checker: name: Check for added todo messages