Skip to content

Commit 6dad429

Browse files
Merge pull request #574 from nextcloud/fix/building-docker-images
Build all images for docker hub correctly
2 parents a53fa35 + fa2fe60 commit 6dad429

File tree

3 files changed

+5
-0
lines changed

3 files changed

+5
-0
lines changed

.github/actions/run-tests/run-locally.sh

+2
Original file line numberDiff line numberDiff line change
@@ -559,6 +559,8 @@ if [ -z "$RUNNER_GID" ]; then
559559
fi
560560
export RUNNER_GID
561561

562+
echo "Using PHP version $PHP_VERSION"
563+
562564
##### Start processing the tasks at hand
563565

564566

.github/workflows/build-test-images.yml

+1
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ jobs:
2828
| docker login
2929
--username ${{ secrets.DOCKER_HUB_USERNAME }}
3030
--password-stdin &&
31+
PHP_VERSION=${{ matrix.phpVersion }}
3132
./run-locally.sh --pull --create-images --push-images

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@
4545
[#554](https://github.com/nextcloud/cookbook/pull/554) @christianlupus
4646
- Introduced updating recipe directory to Vuex state, fixes #542
4747
[#546](https://github.com/nextcloud/cookbook/pull/546/) @seyfeb
48+
- Push docker images for different PHP versions
49+
[#574](https://github.com/nextcloud/cookbook/pull/574) @christianlupus
4850

4951
### Removed
5052
- Removal of old contoller no longer in use

0 commit comments

Comments
 (0)