Change port from 400 to 422

Signed-off-by: Christian Wolf <[email protected]>

Author: christianlupus

docs/dev/api/0.0.3/openapi-cookbook.yaml

@@ -424,14 +424,14 @@ paths:
                 type: integer
                 example: 2462
                 description: The id of the newly created recipe
-        400:
-          description: There was no name in the request given for the recipe. Cannot save the recipe.
+        409:
+          description: A recipe with the name was already found on the server. No recipe is created.
           content:
             application/json:
               schema:
                 $ref: "#/components/schemas/Error"
-        409:
-          description: A recipe with the name was already found on the server. No recipe is created.
+        422:
+          description: There was no name in the request given for the recipe. Cannot save the recipe.
           content:
             application/json:
               schema:
@@ -479,7 +479,7 @@ paths:
                 type: integer
                 description: The id of the updated recipe
                 example: 2345
-        400:
+        422:
           description: There was no name in the request given for the recipe. Cannot save the recipe.
           content:
             application/json:

lib/Controller/RecipeController.php

@@ -109,7 +109,7 @@ public function update($id) {
 				'file' => $ex->getFile(),
 				'line' => $ex->getLine(),
 			];
-			return new JSONResponse($json, Http::STATUS_BAD_REQUEST);
+			return new JSONResponse($json, Http::STATUS_UNPROCESSABLE_ENTITY);
 		}
 		$this->dbCacheService->addRecipe($file);
 
@@ -148,7 +148,7 @@ public function create() {
 				'file' => $ex->getFile(),
 				'line' => $ex->getLine(),
 			];
-			return new JSONResponse($json, Http::STATUS_BAD_REQUEST);
+			return new JSONResponse($json, Http::STATUS_UNPROCESSABLE_ENTITY);
 		}
 	}
 

src/components/RecipeEdit.vue

@@ -596,8 +596,8 @@ export default {
                         // Non 2xx state returned
 
                         switch (e.response.status) {
-                            case 400:
                             case 409:
+                            case 422:
                                 // eslint-disable-next-line no-alert
                                 alert(e.response.data.msg)
                                 break

tests/Unit/Controller/RecipeControllerTest.php

@@ -111,7 +111,7 @@ public function testUpdateNoName(): void {
 
 		$ret = $this->sut->update(1);
 
-		$this->assertEquals(400, $ret->getStatus());
+		$this->assertEquals(422, $ret->getStatus());
 		$this->assertEquals($errorMsg, $ret->getData()['msg']);
 	}
 
@@ -154,7 +154,7 @@ public function testCreateNoName(): void {
 
 		$ret = $this->sut->create();
 
-		$this->assertEquals(400, $ret->getStatus());
+		$this->assertEquals(422, $ret->getStatus());
 		$this->assertEquals($errorMsg, $ret->getData()['msg']);
 	}