Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New contact" text in name field shall be selected when clicking on it #697

Closed
johkoenig opened this issue Nov 7, 2018 · 3 comments
Closed
Labels
3. to review Waiting for reviews bug Something isn't working papercut Annoying recurring issue with possibly simple fix.
Milestone

Comments

@johkoenig
Copy link
Member

johkoenig commented Nov 7, 2018

Describe the bug

When creating a new contact, the name New contact is prefilled. However, when clicking onto that, the text New contact doesn't vanish, it must be removed manually by the user. For Organisation and Title, this is not the case. When I click on one of these and start typing, they vanish. Only the typed text remains.

To Reproduce
Steps to reproduce the behavior:

  1. Click + New contact
  2. Try to add the name by clicking into the name field, which is prefilled with New contact
  3. Type John Doe

Expected behavior
New contact vanishes, name field is filled with John Doe
Basically, name should behave the same way as title and organisation

Actual behavior
The name field is filled with New conJohn Doetact

Server configuration

Nextcloud version: 14.0.3
Contacts version: 2.1.6

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #189 (Group broken when creating new contact), #581 (Contact photos dont show up until you click on the contact), #529 (Contact search button and search text field display below scrolled list entries when list scrolled.), #33 (Contact image improvements), and #156 (Adding a contact when group is selected creates new groups).

@nextcloud-bot nextcloud-bot added the bug Something isn't working label Nov 7, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Nov 7, 2018

Hello, thanks a lot for your report!
This is done on purpose because of the way we create the 'new contact' contact on the background.
If clicking the input select the whole text, would this seems to be a proper fix for you?

@johkoenig
Copy link
Member Author

johkoenig commented Nov 7, 2018

Yes, this would be acceptable.
My expected behavior is "click" -> "write" and not "click" -> "select" -> "delete" -> "write", which would be fulfilled if the text is selected on click.

@skjnldsv skjnldsv added this to the 3.0.0 milestone Nov 7, 2018
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. labels Nov 7, 2018
@johkoenig johkoenig changed the title "New contact" text should vanish when clicking on it "New contact" text in name field shall be selected when clicking on it Nov 7, 2018
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests

3 participants