Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shortcuts and place them into settings #2827

Open
JuliaKirschenheuter opened this issue Jul 13, 2022 · 5 comments
Open

Create shortcuts and place them into settings #2827

JuliaKirschenheuter opened this issue Jul 13, 2022 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request

Comments

@JuliaKirschenheuter
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Accessibility issue.

Please create shortcuts for contacts and place them into settings (like in Mail or Calendar app).

Some shortcuts (especially character key shortcuts) can interfere with shortcuts used by some assistive technologies. Please make sure that the shortcuts don’t interfere with screen reader commands (NVDA, Jaws, Orca).

See more here
https://www.w3.org/TR/WCAG21/#character-key-shortcuts
https://webtest.bitv-test.de/index.php?a=di&iid=269&s=n

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@JuliaKirschenheuter JuliaKirschenheuter added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of labels Jul 13, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Sep 14, 2022

Server PR for a global setting to opt out of keyboard shortcuts to satisfy accessibility is in:

Method to check: OCP.Accessibility.disableKeyboardShortcuts()

If that is true the app(s) must not register ANY shortcuts.

@ChristophWurst
Copy link
Member

Initial state to check is: loadState('theming', 'shortcutsDisabled', false)

Can we have some kind of API for this? Feels a bit strange to me if we fetch an initial state of another app.

@nickvergessen
Copy link
Member

Can we have some kind of API for this?

Anything you have in mind? Yet another package, or just a global function in server/core which then relies on the initialstate?

@ChristophWurst
Copy link
Member

Whatever makes this an official API that we can document. But I see that there is no time to address this properly at the moment.

@nickvergessen
Copy link
Member

OCP.Accessibility.disableKeyboardShortcuts() was added as discussed in the chat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants