Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems while import vcards #16

Closed
DerSaxxe opened this issue Oct 24, 2016 · 6 comments
Closed

Problems while import vcards #16

DerSaxxe opened this issue Oct 24, 2016 · 6 comments
Labels
bug Something isn't working needs info Not enough information provided

Comments

@DerSaxxe
Copy link

I had the following problems:

  1. comma where replaced with , -> I removed the replace command in vcard.js
  2. several problems with tel types while import vcard v2.1
  3. several problems with quoted-printable values while import vcard v2.1

To avoid 2. and 3. I converted all vcards to v3.0 with a little sed-script.

@irgendwie irgendwie added bug Something isn't working 1. to develop Accepted and waiting to be taken care of needs info Not enough information provided and removed 1. to develop Accepted and waiting to be taken care of labels Oct 24, 2016
@irgendwie
Copy link
Member

  1. Known issue with the vcard lib we are using (Multiple categories are escaped to one Heymdall/vcard#5), not completely fixed by now - some values need to be escaped that way.
  2. Could you please explain a bit more about the problem?
  3. Quoted-printable is currently not supported but was already mentioned before the fork (ref Vcf import failed - values are not decoded from quoted-printable format owncloud/contacts#399, importet contacts with "umlaute" ä/ö/ü are not correct owncloud/contacts#503)

@DerSaxxe
Copy link
Author

  1. Thanks for this information
  2. I'll do a fresh nextcloud installation to exlain it step by step this week
  3. That's the problem because exporting i.e. contacts with german umlauts or ß from EGroupware v1.8 you get vcard v2.1 with quoted-printable-strings.

@irgendwie
Copy link
Member

I'm sorry for the inconveniences! I was already looking for some libraries, dealing with quoted printables since Thunderbird/Lightning is also exporting VCards with that encoding. But I didn't have time to implement it by now. PRs are very welcomed!

@DerSaxxe
Copy link
Author

Let me explain some problems while import vcard v2.1 without quoted printable:

  1. ADR;HOME;... was imported as ADR;HOME=; thats why no type for the address was shown
  2. TEL;CELL;HOME:... was imported as TEL;CELL=;HOME=:
  3. EGroupware exports 2 ORG-fields (i.e. ORG:Versicherung;Baden-Badener;). After import there is only the first field visible but if you look at the imported data there are both fields. Also after sync with the phone the second field is visible there. Maybe "contacts" need a second field?

So I cannot advise to import vcard v2.1

@xenji
Copy link

xenji commented Nov 5, 2016

Regarding the problem described in 1., I tried to submit a patch which I think fixes the other part of the problem. See Heymdall/vcard#6

Works for me, but still, this needs proof from more ppl.

@xenji
Copy link

xenji commented Dec 1, 2016

FYI The patch has been merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs info Not enough information provided
Projects
None yet
Development

No branches or pull requests

4 participants