diff --git a/src/models/contact.js b/src/models/contact.js index 1240d3d293..f12cef50e4 100644 --- a/src/models/contact.js +++ b/src/models/contact.js @@ -285,7 +285,10 @@ export default class Contact { const org = this.vCard.getFirstPropertyValue('org') // if ordered by last or first name we need the N property - if (orderKey && n) { + // ! by checking the property we check for null AND empty string + // ! that means we can then check for empty array and be safe not to have + // ! 'xxxx'.join('') !== '' + if (orderKey && n && n.join('') !== '') { switch (orderKey) { case 'firstName': // Stevenson;John;Philip,Paul;Dr.;Jr.,M.D.,A.C.P. @@ -299,20 +302,19 @@ export default class Contact { } } // otherwise the FN is enough - if (this.vCard.hasProperty('fn')) { + if (fn) { return fn } // BUT if no FN property use the N anyway - if (n) { + if (n && n.join('') !== '') { // Stevenson;John;Philip,Paul;Dr.;Jr.,M.D.,A.C.P. // -> John Stevenson return n.slice(0, 2).reverse().join(' ') } // LAST chance, use the org ir that's the only thing we have - if (org) { - // Stevenson;John;Philip,Paul;Dr.;Jr.,M.D.,A.C.P. - // -> John Stevenson - return org + if (org && org.join('') !== '') { + // org is supposed to be an array but is also used as plain string + return Array.isArray(org) ? org[0] : org } return '' diff --git a/src/services/checks/missingFN.js b/src/services/checks/missingFN.js index 3c7ea9e64e..1f17afc85e 100644 --- a/src/services/checks/missingFN.js +++ b/src/services/checks/missingFN.js @@ -27,7 +27,8 @@ export default { name: 'missing FN', run: contact => { - return !contact.vCard.hasProperty('fn') + return !contact.vCard.hasProperty('fn') // No FN + || contact.vCard.getFirstPropertyValue('fn') === '' // Empty FN }, fix: contact => { if (contact.vCard.hasProperty('n')) {