feat: client interceptor #1812
feat: client interceptor #1812
Conversation
Signed-off-by: alperozturk <[email protected]>
|
|
||
| @Throws(IOException::class) | ||
| fun execute(method: OkHttpMethodBase): Int { | ||
| interceptor.interceptOkHttpMethodBaseRequest(method) |
There was a problem hiding this comment.
How can I completely bypass the interception process? Currently, LogOC not going to print anything in prod, but I would also like to skip the parsing step altogether. When I checked the isEnabled value in LogOC, it returned false during my local tests, even though it should be enabled.
There was a problem hiding this comment.
| interceptor.interceptOkHttpMethodBaseRequest(method) | |
| if (BuildConfig.DEBUG) { | |
| interceptor.interceptOkHttpMethodBaseRequest(method) | |
| } |
Maybe something like that?
There was a problem hiding this comment.
In some cases (such as beta or QA versions), even in release mode, we want to track logs to detect issues.
There was a problem hiding this comment.
Seems Log_OC inside libray is not started.
I will check it.
There was a problem hiding this comment.
Idea: move files' logger to library logging
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4442-IT-master-13-29/debug/ |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4442-IT-stable-13-29/debug/ |
This PR adds interceptor to the clients.