Skip to content

fix twitter/X test #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025
Merged

fix twitter/X test #1717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f272885
fix twitter/X test
tobiasKaminsky May 7, 2025
fbd880e
add some debug output
tobiasKaminsky May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/androidTest/java/com/owncloud/android/lib/common/operations/RemoveShareIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public void testRemoveShare() throws IOException {
false,
"", 1).execute(client);

assertTrue(result.isSuccess());
assertTrue(result.getLogMessage(), result.isSuccess());

OCShare ocShare = result.getResultData().get(0);

Expand Down
3 changes: 2 additions & 1 deletion ...ary/src/androidTest/java/com/owncloud/android/lib/resources/files/FilesDownloadLimitIT.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import com.owncloud.android.lib.resources.status.GetCapabilitiesRemoteOperation
import com.owncloud.android.lib.resources.status.NextcloudVersion
import com.owncloud.android.lib.resources.status.OCCapability
import junit.framework.TestCase.assertEquals
import junit.framework.TestCase.assertTrue
import org.junit.Before
import org.junit.Test

Expand Down Expand Up @@ -102,7 +103,7 @@ class FilesDownloadLimitIT : AbstractIT() {
1
).execute(client)

assert(result.isSuccess)
assertTrue(result.getLogMessage(), result.isSuccess)
val share = result.resultData.first()
assert(share.token != null)
return share
Expand Down
5 changes: 3 additions & 2 deletions ...droidTest/java/com/owncloud/android/lib/resources/users/SetUserInfoRemoteOperationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,15 @@ public void testSetTwitter() {
RemoteOperationResult<UserInfo> userInfo = new GetUserInfoRemoteOperation().execute(nextcloudClient);
assertTrue(userInfo.isSuccess());
String oldValue = userInfo.getResultData().getTwitter();
String newValue = "Nextclouders";

// set
assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, "@Nextclouders")
assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, newValue)
.execute(nextcloudClient).isSuccess());

userInfo = new GetUserInfoRemoteOperation().execute(nextcloudClient);
assertTrue(userInfo.isSuccess());
assertEquals("@Nextclouders", userInfo.getResultData().getTwitter());
assertEquals(newValue, userInfo.getResultData().getTwitter());

// reset
assertTrue(new SetUserInfoRemoteOperation(SetUserInfoRemoteOperation.Field.TWITTER, oldValue)
Expand Down
Loading