Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

No description provided.

AndyScherzinger
AndyScherzinger previously approved these changes Dec 7, 2023
@codecov
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1267 (ce67919) into master (2b1da4c) will increase coverage by 4.23%.
The diff coverage is n/a.

❗ Current head ce67919 differs from pull request most recent head 012fcde. Consider uploading reports for the commit 012fcde to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1267      +/-   ##
============================================
+ Coverage     48.57%   52.81%   +4.23%     
  Complexity      977      977              
============================================
  Files           200      190      -10     
  Lines          7697     7061     -636     
  Branches        989      927      -62     
============================================
- Hits           3739     3729      -10     
+ Misses         3438     2817     -621     
+ Partials        520      515       -5     
Files Coverage Δ
...oid/lib/resources/dashboard/DashBoardButtonType.kt 100.00% <ø> (ø)
...android/lib/resources/dashboard/DashboardButton.kt 20.00% <ø> (ø)
...ashboard/DashboardGetWidgetItemsRemoteOperation.kt 78.26% <ø> (ø)
...s/dashboard/DashboardListWidgetsRemoteOperation.kt 77.77% <ø> (ø)
...android/lib/resources/dashboard/DashboardWidget.kt 25.00% <ø> (ø)
...oid/lib/resources/dashboard/DashboardWidgetItem.kt 80.00% <ø> (ø)
...oid/lib/resources/dashboard/DashboardWidgetList.kt 0.00% <ø> (ø)
...ectediting/DirectEditingObtainRemoteOperation.java 63.63% <ø> (ø)
...es/search/UnifiedSearchProvidersRemoteOperation.kt 50.00% <ø> (-1.73%) ⬇️
...b/resources/search/UnifiedSearchRemoteOperation.kt 68.08% <ø> (-0.67%) ⬇️
... and 6 more

... and 45 files with indirect coverage changes

@github-actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@AndyScherzinger AndyScherzinger merged commit 5a31f24 into master Feb 13, 2024
@delete-merged-branch delete-merged-branch bot deleted the license branch February 13, 2024 07:27
@AndyScherzinger AndyScherzinger added this to the NC Android lib 2.19.0 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants