Merge pull request #983 from nextcloud/fix/execute_NPE

AlvaroBrey · web-flow · commit 12982fe8a02b · 2022-10-31T12:47:28.000+01:00
OkHttpMethodBase: prevent NPE when logging exception
diff --git a/library/src/main/java/com/nextcloud/common/OkHttpMethodBase.kt b/library/src/main/java/com/nextcloud/common/OkHttpMethodBase.kt
@@ -174,7 +174,7 @@ abstract class OkHttpMethodBase(
         try {
             response = client.client.newCall(request).execute()
         } catch (ex: IOException) {
-            Log_OC.e(this, ex.message, ex)
+            Log_OC.e(this, "Error executing method", ex)
         }
 
         return response?.code ?: UNKNOWN_STATUS_CODE

Original file line number	Diff line number	Diff line change
`@@ -174,7 +174,7 @@ abstract class OkHttpMethodBase(`
`174`	`174`	`try {`
`175`	`175`	`response = client.client.newCall(request).execute()`
`176`	`176`	`} catch (ex: IOException) {`
`177`		`- Log_OC.e(this, ex.message, ex)`
	`177`	`+ Log_OC.e(this, "Error executing method", ex)`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`return response?.code ?: UNKNOWN_STATUS_CODE`