fix findings of detekt

do no allow any issues on detekt

Signed-off-by: tobiasKaminsky <[email protected]>

Author: tobiasKaminsky

library/detekt.yml

@@ -1,5 +1,5 @@
 build:
-  maxIssues: 8
+  maxIssues: 0
   weights:
   # complexity: 2
   # LongParameterList: 1

library/src/androidTest/java/com/nextcloud/common/NextcloudUriDelegateIT.kt

@@ -15,28 +15,28 @@ class NextcloudUriDelegateIT {
     }
 
     @Test
-    fun testFilesDavUri_leadingSlashInPath() {
+    fun testFilesDavUriLeadingSlashInPath() {
         val expected = "$EXPECTED_FILES_DAV/path/to/file.txt"
         val actual = sut.getFilesDavUri("/path/to/file.txt")
         Assert.assertEquals("Wrong URL", expected, actual)
     }
 
     @Test
-    fun testFilesDavUri_noLeadingSlashInPath() {
+    fun testFilesDavUriLoLeadingSlashInPath() {
         val expected = "$EXPECTED_FILES_DAV/path/to/file.txt"
         val actual = sut.getFilesDavUri("path/to/file.txt")
         Assert.assertEquals("Wrong URL", expected, actual)
     }
 
     @Test
-    fun testFilesDavUri_emptyPath() {
+    fun testFilesDavUriEmptyPath() {
         val expected = "$EXPECTED_FILES_DAV/"
         val actual = sut.getFilesDavUri("")
         Assert.assertEquals("Wrong URL", expected, actual)
     }
 
     @Test
-    fun testFilesDavUri_rootPath() {
+    fun testFilesDavUriRootPath() {
         val expected = "$EXPECTED_FILES_DAV/"
         val actual = sut.getFilesDavUri("/")
         Assert.assertEquals("Wrong URL", expected, actual)

library/src/androidTest/java/com/owncloud/android/lib/resources/shares/ShareXMLParserIT.kt

@@ -30,6 +30,7 @@ import junit.framework.Assert.assertEquals
 import junit.framework.Assert.assertTrue
 import org.junit.Test
 
+@Suppress("LargeClass", "LongMethod")
 class ShareXMLParserIT {
     @Test
     fun testOCShareResponse() {

library/src/main/java/com/nextcloud/common/NextcloudClient.kt

@@ -124,6 +124,7 @@ class NextcloudClient private constructor(
     }
 
     @Throws(IOException::class)
+    @Suppress("NestedBlockDepth")
     fun followRedirection(method: OkHttpMethodBase): RedirectionPath {
         var redirectionsCount = 0
         var status = method.getStatusCode()
@@ -133,10 +134,9 @@ class NextcloudClient private constructor(
             status == HttpStatus.SC_MOVED_TEMPORARILY ||
             status == HttpStatus.SC_TEMPORARY_REDIRECT
         while (redirectionsCount < OwnCloudClient.MAX_REDIRECTIONS_COUNT && statusIsRedirection) {
-            var location = method.getResponseHeader("Location")
-            if (location == null) {
-                location = method.getResponseHeader("location")
-            }
+            val location = method.getResponseHeader("Location")
+                ?: method.getResponseHeader("location")
+
             if (location != null) {
                 Log_OC.d(TAG, "Location to redirect: $location")
                 result.addLocation(location)
@@ -145,10 +145,7 @@ class NextcloudClient private constructor(
                 method.releaseConnection()
                 method.uri = location
                 var destination = method.getRequestHeader("Destination")
-
-                if (destination == null) {
-                    destination = method.getRequestHeader("destination")
-                }
+                    ?: method.getRequestHeader("destination")
 
                 if (destination != null) {
                     val suffixIndex = location.lastIndexOf(AccountUtils.WEBDAV_PATH_9_0)
@@ -164,12 +161,14 @@ class NextcloudClient private constructor(
                         method.addRequestHeader("Destination", destination)
                     }
                 }
+
                 status = method.execute(this)
                 result.addStatus(status)
                 redirectionsCount++
             } else {
                 Log_OC.d(TAG, "No location to redirect!")
                 status = HttpStatus.SC_NOT_FOUND
+                result.addStatus(status)
             }
         }
         return result

library/src/main/java/com/nextcloud/common/OkHttpMethodBase.kt

@@ -124,8 +124,8 @@ abstract class OkHttpMethodBase(
         return response?.header(name)
     }
 
-    fun getRequestHeader(name: String): String {
-        return request?.header(name) ?: ""
+    fun getRequestHeader(name: String): String? {
+        return request?.header(name)
     }
 
     /**