Merge pull request #5194 from nextcloud-libraries/fix/5159/navigation-new-item-regression

raimund-schluessler · web-flow · commit 83d844de4cde · 2024-01-31T14:40:22.000+01:00
fix(NcAppNavigationNewItem): bring back correct CSS class
diff --git a/src/assets/NcAppNavigationItem.scss b/src/assets/NcAppNavigationItem.scss
@@ -34,7 +34,7 @@
 		}
 
 		// overwrite active text color
-		.app-navigation-entry-link {
+		.app-navigation-entry-link, .app-navigation-entry-button {
 			color: var(--color-primary-element-text) !important;
 		}
 	}
@@ -68,12 +68,14 @@
 		display: none;
 	}
 
-	&:not(.app-navigation-entry--editing) .app-navigation-entry-link {
-		padding-right: $icon-margin;
+	&:not(.app-navigation-entry--editing) {
+		.app-navigation-entry-link, .app-navigation-entry-button {
+			padding-right: $icon-margin;
+		}
 	}
 
 	// Main entry link
-	.app-navigation-entry-link {
+	.app-navigation-entry-link, .app-navigation-entry-button {
 		z-index: 100; /* above the bullet to allow click*/
 		display: flex;
 		overflow: hidden;

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`// overwrite active text color`
`37`		`- .app-navigation-entry-link {`
	`37`	`+ .app-navigation-entry-link, .app-navigation-entry-button {`
`38`	`38`	`color: var(--color-primary-element-text) !important;`
`39`	`39`	`}`
`40`	`40`	`}`
`@@ -68,12 +68,14 @@`
`68`	`68`	`display: none;`
`69`	`69`	`}`
`70`	`70`
`71`		`- &:not(.app-navigation-entry--editing) .app-navigation-entry-link {`
`72`		`- padding-right: $icon-margin;`
	`71`	`+ &:not(.app-navigation-entry--editing) {`
	`72`	`+ .app-navigation-entry-link, .app-navigation-entry-button {`
	`73`	`+ padding-right: $icon-margin;`
	`74`	`+ }`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`// Main entry link`
`76`		`- .app-navigation-entry-link {`
	`78`	`+ .app-navigation-entry-link, .app-navigation-entry-button {`
`77`	`79`	`z-index: 100; /* above the bullet to allow click*/`
`78`	`80`	`display: flex;`
`79`	`81`	`overflow: hidden;`