Merge pull request #796 from nextcloud-libraries/fix/make-module-resolution-explicit

susnux · web-flow · commit c2d3845ee400 · 2024-01-10T21:19:21.000+01:00
fix: Add explicit file extension to fix module resolution with Webpack
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## 1.3.1 - 2024-01-10
+### Fixed
+* Fixed module resolution when using webpack + babel
+
 ## 1.3.0 - 2024-01-10
 ### Enhancements
 * enh: Move package to vite for bundling + compress translations [#781](https://github.com/nextcloud-libraries/nextcloud-moment/pull/781) \([susnux](https://github.com/susnux)\)
diff --git a/lib/constants.d.ts b/lib/constants.d.ts
@@ -4,3 +4,8 @@ interface Translations {
 }
 
 declare const LOCALES: Translations[]
+
+declare module 'moment/min/moment-with-locales.js' {
+	import moment from 'moment'
+	export default moment
+}
diff --git a/lib/index.ts b/lib/index.ts
@@ -1,4 +1,4 @@
-import moment from 'moment/min/moment-with-locales'
+import moment from 'moment/min/moment-with-locales.js'
 import Gettext from 'node-gettext'
 import { getLocale } from '@nextcloud/l10n'
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@nextcloud/moment",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "Customized moment.js for Nextcloud",
   "main": "dist/index.cjs",
   "types": "dist/index.d.ts",

Original file line number	Diff line number	Diff line change
`@@ -4,3 +4,8 @@ interface Translations {`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`declare const LOCALES: Translations[]`
	`7`	`+`
	`8`	`+declare module 'moment/min/moment-with-locales.js' {`
	`9`	`+ import moment from 'moment'`
	`10`	`+ export default moment`
	`11`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import moment from 'moment/min/moment-with-locales'`
	`1`	`+import moment from 'moment/min/moment-with-locales.js'`
`2`	`2`	`import Gettext from 'node-gettext'`
`3`	`3`	`import { getLocale } from '@nextcloud/l10n'`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@nextcloud/moment",`
`3`		`- "version": "1.3.0",`
	`3`	`+ "version": "1.3.1",`
`4`	`4`	`"description": "Customized moment.js for Nextcloud",`
`5`	`5`	`"main": "dist/index.cjs",`
`6`	`6`	`"types": "dist/index.d.ts",`