Skip to content

Commit fd44704

Browse files
committed
test: Adjust tests for new @nextcloud/files functions
Signed-off-by: Ferdinand Thiessen <[email protected]>
1 parent b0429b2 commit fd44704

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/components/FilePicker/FileList.spec.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const exampleNodes = [
3232
root: '/',
3333
size: 321,
3434
attributes: {
35-
favorite: true,
35+
favorite: 1,
3636
},
3737
}),
3838
new Folder({
@@ -157,10 +157,10 @@ describe('FilePicker FileList', () => {
157157
const rows = wrapper.findAll('[data-testid="file-list-row"]')
158158
// all nodes are shown
159159
expect(rows.length).toBe(nodes.length)
160-
// folder are sorted first
161-
expect(rows.at(0).attributes('data-filename')).toBe('directory')
162160
// by default favorites are sorted before other files
163-
expect(rows.at(1).attributes('data-filename')).toBe('favorite.txt')
161+
expect(rows.at(0).attributes('data-filename')).toBe('favorite.txt')
162+
// folder are sorted first
163+
expect(rows.at(1).attributes('data-filename')).toBe('directory')
164164
// other files are ascending
165165
expect(rows.at(2).attributes('data-filename')).toBe('a-file.txt')
166166
expect(rows.at(3).attributes('data-filename')).toBe('b-file.txt')
@@ -192,10 +192,10 @@ describe('FilePicker FileList', () => {
192192
const rows = wrapper.findAll('.file-picker__row')
193193
// all nodes are shown
194194
expect(rows.length).toBe(nodes.length)
195-
// folder are sorted first
196-
expect(rows.at(0).attributes('data-filename')).toBe('directory')
197195
// by default favorites are sorted before other files
198-
expect(rows.at(1).attributes('data-filename')).toBe('favorite.txt')
196+
expect(rows.at(0).attributes('data-filename')).toBe('favorite.txt')
197+
// folder are sorted first
198+
expect(rows.at(1).attributes('data-filename')).toBe('directory')
199199
// other files are descending
200200
expect(rows.at(2).attributes('data-filename')).toBe('b-file.txt')
201201
expect(rows.at(3).attributes('data-filename')).toBe('a-file.txt')

lib/components/FilePicker/FileList.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ const { sortFavoritesFirst, cropImagePreviews } = useFilesSettings()
142142
*/
143143
const sortedFiles = computed(() => {
144144
return sortNodes(props.files, {
145-
sortFavoritesFirst: sortFavoritesFirst.value,
146145
sortFoldersFirst: true,
146+
sortFavoritesFirst: sortFavoritesFirst.value,
147147
sortingOrder: sortingConfig.value.order === 'descending' ? 'desc' : 'asc',
148148
sortingMode: sortingConfig.value.sortBy as FilesSortingMode,
149149
})

0 commit comments

Comments
 (0)