You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi 👋 ,
I built a database adapter for cloudflare D1. I feel like i'm close to ready for a PR. It passes the unit test suite in the adapter-test package. I have a demo app based on the svelte example & Cloudflare pages. It works locally. I have deployed it to cloudflare pages as well as a production test. Everything looks good so far. Basic login / logout with Github and database session strategy works fine. I'm guessing it needs docs before I open a PR. Should those docs reference next-auth or authjs ? For instance the supabase adapter starts off with: "This is the Supabase Adapter for next-auth. This package can only be used in conjunction with the primary next-auth package. It is not a standalone package." Should I emulate the supabase adapter documentation or some other adapter's docs? Should I write it for the future authjs adapter docs?
One note, the unit testing is reliant on @miniflare/d1 to mock the Cloudflare production d1. It had a subtle bug that made it not work when running in Jest, a native type e instanceof TypeError comparison that doesn't work when using the vm api. I submitted a PR and they accepted it and its merged to main but they haven't published to NPM yet. I have a version published at @jschlesser/d1 so that the adapter-test suite passes. I could alternatively use patch-package on @miniflare/d1 instead if that works better till they get around to running npm publish.
How should I proceed?
Thanks,
Josh
How to reproduce ☕️
There isn't anything to reproduce, it's just a question about how to proceed.
Contributing 🙌🏽
Yes, I am willing to help answer this question in a PR
The text was updated successfully, but these errors were encountered:
Question 💬
Hi 👋 ,
I built a database adapter for cloudflare D1. I feel like i'm close to ready for a PR. It passes the unit test suite in the adapter-test package. I have a demo app based on the svelte example & Cloudflare pages. It works locally. I have deployed it to cloudflare pages as well as a production test. Everything looks good so far. Basic login / logout with Github and database session strategy works fine. I'm guessing it needs docs before I open a PR. Should those docs reference next-auth or authjs ? For instance the supabase adapter starts off with: "This is the Supabase Adapter for
next-auth
. This package can only be used in conjunction with the primarynext-auth
package. It is not a standalone package." Should I emulate the supabase adapter documentation or some other adapter's docs? Should I write it for the future authjs adapter docs?One note, the unit testing is reliant on @miniflare/d1 to mock the Cloudflare production d1. It had a subtle bug that made it not work when running in Jest, a native type
e instanceof TypeError
comparison that doesn't work when using the vm api. I submitted a PR and they accepted it and its merged to main but they haven't published to NPM yet. I have a version published at @jschlesser/d1 so that the adapter-test suite passes. I could alternatively use patch-package on @miniflare/d1 instead if that works better till they get around to runningnpm publish
.How should I proceed?
Thanks,
Josh
How to reproduce ☕️
There isn't anything to reproduce, it's just a question about how to proceed.
Contributing 🙌🏽
Yes, I am willing to help answer this question in a PR
The text was updated successfully, but these errors were encountered: